fix: limit the maximum number of tags per extensin version - #2009
Merged
Conversation
…ke it configurable
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a configurable cap on the number of tags persisted per published extension version (addressing #1968), defaulting to 20 tags while allowing overrides via ovsx.publishing.max-tags.
Changes:
- Add
ovsx.publishing.max-tagsconfiguration (default 20) and apply it at publish-time when persisting extracted metadata. - Implement tag capping and case-insensitive de-duplication behavior in
ExtensionProcessor. - Add/adjust tests to cover default limit behavior, configurability, and publish endpoint behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/src/main/java/org/eclipse/openvsx/ExtensionProcessor.java | Adds default tag cap and getMetadata(int) plumbing; caps/dedupes tags during metadata extraction. |
| server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java | Ensures persisted metadata respects the configured tag limit. |
| server/src/main/java/org/eclipse/openvsx/publish/PublishingConfig.java | Introduces maxTags configuration property with default value. |
| server/src/test/java/org/eclipse/openvsx/ExtensionProcessorTest.java | Adds unit tests for default limit, configurability, disabling, and distinct-tag counting. |
| server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java | Adds an API-level publish test verifying tag limiting and adjusts test package creation to include tags. |
| server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionConcurrencyTest.java | Updates mocking to match the new getMetadata(int) call shape. |
| server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java | Updates mocking to match the new getMetadata(int) call shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1968 .
There is now a new configuration value
ovsx.publishing.max-tagswith a default of `20.