Skip to content

chore: remove deprecated fields in ExtensionJson - #2024

Merged
netomi merged 5 commits into
mainfrom
remove-deprecated-fields
Jul 31, 2026
Merged

chore: remove deprecated fields in ExtensionJson#2024
netomi merged 5 commits into
mainfrom
remove-deprecated-fields

Conversation

@netomi

@netomi netomi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

This PR removes two fields in the ExtensionJson response object that are deprecated for a long time:

  • namespaceAccess
  • unrelatedPublisher

The do not fit into the current model anymore and should not be used.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes two long-deprecated properties (namespaceAccess, unrelatedPublisher) from the server-side ExtensionJson API model and stops populating them in registry responses, aligning the JSON response shape with the current namespace/verification model.

Changes:

  • Removed deprecated unrelatedPublisher and namespaceAccess fields (and their getters/setters) from ExtensionJson.
  • Removed server-side population of those fields in LocalRegistryService and deleted the now-unused RESTRICTED_ACCESS constant.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java Stops setting deprecated ExtensionJson fields and removes unused constant.
server/src/main/java/org/eclipse/openvsx/json/ExtensionJson.java Removes deprecated fields and updates equals/hashCode accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@netomi

netomi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

There are more deprecated fields, namely allVersions in ExtensionJson and SearchEntryJson. They are in active used and will need a different approach for actual removal.

@netomi
netomi requested a review from cstamas July 31, 2026 12:28
@netomi

netomi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Added some more cleanups to this PR that are harmless.

@netomi
netomi merged commit fdc5d33 into main Jul 31, 2026
8 of 9 checks passed
@netomi
netomi deleted the remove-deprecated-fields branch July 31, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants