chore: remove deprecated fields in ExtensionJson - #2024
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two long-deprecated properties (namespaceAccess, unrelatedPublisher) from the server-side ExtensionJson API model and stops populating them in registry responses, aligning the JSON response shape with the current namespace/verification model.
Changes:
- Removed deprecated
unrelatedPublisherandnamespaceAccessfields (and their getters/setters) fromExtensionJson. - Removed server-side population of those fields in
LocalRegistryServiceand deleted the now-unusedRESTRICTED_ACCESSconstant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java | Stops setting deprecated ExtensionJson fields and removes unused constant. |
| server/src/main/java/org/eclipse/openvsx/json/ExtensionJson.java | Removes deprecated fields and updates equals/hashCode accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
There are more deprecated fields, namely |
cstamas
approved these changes
Jul 31, 2026
Contributor
Author
|
Added some more cleanups to this PR that are harmless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two fields in the
ExtensionJsonresponse object that are deprecated for a long time:The do not fit into the current model anymore and should not be used.