Migrate org.eclipse.ui.workbench.texteditor.tests off JUnit 4 - #4228
Merged
akurtakov merged 1 commit intoAug 6, 2026
Merged
Conversation
The bundle already used JUnit Jupiter everywhere except three helper classes that still statically imported org.junit.Assert. Switch those to org.junit.jupiter.api.Assertions, adjusting the argument order of the assertFalse call that passes a message. With the last JUnit 4 usage gone, drop the org.junit Require-Bundle. That bundle also pulled in Hamcrest transitively, so declare the org.hamcrest package explicitly in Import-Package instead.
Contributor
akurtakov
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bundle was already almost entirely on JUnit Jupiter. Only three helper classes still statically imported
org.junit.Assert, so they are switched over toorg.junit.jupiter.api.Assertions. OneassertFalsecall passes a message, so its argument order is flipped to match the Jupiter signature.With the last JUnit 4 usage gone, the
org.junitRequire-Bundleentry can go too. That bundle also supplied Hamcrest transitively, soorg.hamcrestis now declared explicitly inImport-Package, which makes the real dependency visible instead of relying on a side effect of the JUnit 4 dependency.The bundle now has a single test framework rather than a mix, and one fewer bundle on its classpath. All 222 tests pass locally.