Do not fill in a stack trace for ResourceChangedException - #2885
Merged
vogella merged 1 commit intoSep 1, 2026
Merged
Conversation
Contributor
vogella
force-pushed
the
synchronized-visitor-no-stacktrace
branch
from
August 31, 2026 15:38
3d2777e to
59e9529
Compare
The exception is only a control-flow signal, and its single catch site reads just the target resource.
vogella
force-pushed
the
synchronized-visitor-no-stacktrace
branch
from
September 1, 2026 07:33
59e9529 to
6ab0d92
Compare
There was a problem hiding this comment.
Pull request overview
Avoids unnecessary stack-trace capture for an internal control-flow exception.
Changes:
- Overrides
fillInStackTrace()to return the exception directly. - Preserves existing target-resource handling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsSynchronizedVisitorthrowsResourceChangedExceptionpurely as a control-flow signal for the first out-of-sync node, and its only catch site inFileSystemResourceManagerreads just the target resource. The class comment already states the stack trace is meaningless, so overridingfillInStackTraceavoids capturing one.RefreshLocalTestandUnifiedTreeTestpass unchanged.