Skip to content

feat: install full qemu-system package instead of qemu-system-arm - #142

Merged
lurtz merged 2 commits into
eclipse-score:mainfrom
etas-contrib:qemu-einbauen
Aug 13, 2026
Merged

feat: install full qemu-system package instead of qemu-system-arm#142
lurtz merged 2 commits into
eclipse-score:mainfrom
etas-contrib:qemu-einbauen

Conversation

@AlexanderLanin

@AlexanderLanin AlexanderLanin commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

Replaces the narrower qemu-system-arm package with the full qemu-system meta-package in the devcontainer, so additional system emulators (e.g. x86) are available in addition to arm.

Why qemu-system instead of a single-arch package (qemu-system-arm / qemu-system-x86)?

  • Broader target coverage with one dependency: qemu-system is an Ubuntu meta-package that pulls in qemu-system-arm, qemu-system-x86, qemu-system-mips, qemu-system-ppc, qemu-system-sparc, qemu-system-s390x, and qemu-system-misc. Developers working on this devcontainer may need to emulate/test targets beyond arm (e.g. x86_64), and picking a single-arch package would mean guessing in advance which architectures will ever be needed and adding a new apt-get line/version pin every time a new target shows up.
  • Simpler maintenance: one version-pinned entry in versions.yaml / install.sh instead of one per architecture, which reduces the amount of places to update when the qemu version changes and avoids version-skew between multiple qemu-system-* packages (they all come from the same source package and share a version).
  • Low cost to include: the additional per-arch binaries are small relative to the rest of the devcontainer image, so the convenience of having all common QEMU system emulators available outweighs the marginal size increase versus installing only qemu-system-arm.
  • Future-proofing: if another target architecture becomes relevant for this project, no devcontainer change is required — it's already installed.

Changes

  • versions.yaml: renamed qemu_system_arm version key to qemu_system
  • install.sh: installs qemu-system instead of qemu-system-arm
  • tests/test_default.sh: validates both qemu-system-aarch64 and qemu-system-x86_64

Testing

No local devcontainer build available in this environment; changes follow the existing version-pinning pattern used by other tools in this feature.

Replace qemu-system-arm with the qemu-system meta-package to cover
additional system emulators (e.g. x86) in addition to arm, and add
a corresponding test for qemu-system-x86_64.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Installs the full QEMU system-emulation suite to support additional architectures.

Changes:

  • Renamed the QEMU version key.
  • Replaced qemu-system-arm with qemu-system.
  • Added x86_64 emulator validation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
versions.yaml Renames the QEMU version key.
install.sh Installs the full QEMU system package.
tests/test_default.sh Tests ARM64 and x86_64 emulators.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@AlexanderLanin
AlexanderLanin marked this pull request as ready for review August 13, 2026 13:00

@lurtz lurtz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to restrict it to arm and x86_64. Actually I play with the thought of removing some stuff from the devcontainer to make it smaller or to provide multiple devcontainer images.

I thought a bigger devcontainer would locally not be a big deal, but having multiple instance of VS Code eats at the moment a lot of RAM. I still have to figure out if it is just VS Code or the devcontainer.

At the moment the devcontainer image is 5GB. Here some details where the space used:

Image

In the S-CORE layer codeql should add at least 1GB. I wonder how widely that is used.

Install only the ARM and x86 QEMU system emulator packages instead of the full meta-package.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AlexanderLanin

Copy link
Copy Markdown
Member Author

Agreed. I updated this PR to install only qemu-system-arm and qemu-system-x86, rather than the full qemu-system meta-package. The checks cover both qemu-system-aarch64 and qemu-system-x86_64, so the devcontainer supports exactly the requested targets without bringing in the other system emulators.

@lurtz
lurtz added this pull request to the merge queue Aug 13, 2026
Merged via the queue into eclipse-score:main with commit f9f1b45 Aug 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants