Skip to content

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Nov 11, 2025

Every addition of an external dependency has reset the list. Instead reset the list once, before adding dependencies.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 9c5d4ec4-2ba7-4a47-b589-26f39cd107be
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (71 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2170 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[3 / 12] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 13.308s, Critical Path: 0.32s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot finished reviewing on behalf of AlexanderLanin November 11, 2025 10:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where only the last external dependency was being retained when multiple dependencies were configured. The fix moves the initialization of config.needs_external_needs = [] from inside the add_external_needs_json function (which is called in a loop) to the connect_external_needs function (before the loop starts).

  • Relocated list initialization from add_external_needs_json to connect_external_needs
  • Ensured that multiple external needs can be accumulated correctly instead of being overwritten

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Copy link
Contributor

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for the fix.

@AlexanderLanin AlexanderLanin merged commit bb52c96 into eclipse-score:main Nov 11, 2025
13 checks passed
@AlexanderLanin AlexanderLanin deleted the fix branch November 11, 2025 11:07
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants