Skip to content

Conversation

@MaximilianSoerenPollak
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak commented May 27, 2025

Remove defined external 'id_prefixes' from to be checked links.
Added another example to have an rst file inside a folder as well.
Added some explanation to descriptions of needs.
Upgrade dependency of score_platform

closes #47

RST file based tests seem to be more involved than thought, will add these in later PR.
Have to figure our how to implement those first.
Tracking that here #49

@github-actions
Copy link

github-actions bot commented May 27, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ✅ Passed

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 31bd4371-c18b-4c77-b620-010504967079
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (102 packages loaded, 10 targets configured)

Analyzing: target //src:license-check (145 packages loaded, 1192 targets configured)

Analyzing: target //src:license-check (151 packages loaded, 2633 targets configured)

Analyzing: target //src:license-check (156 packages loaded, 2668 targets configured)

Analyzing: target //src:license-check (159 packages loaded, 4677 targets configured)

INFO: Analyzed target //src:license-check (161 packages loaded, 4927 targets configured).
[6 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker~/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 15.050s, Critical Path: 0.40s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/docs-as-code -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 76 items.
[main] INFO Found 54 items.
[main] INFO Querying ClearlyDefined for license data for 22 items.
[main] INFO Found 22 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

Remove defined external 'id_prefixes' from to be checked links.
Added another example to have an rst file inside a folder as well.
Added some explanation to descriptions of needs
AlexanderLanin
AlexanderLanin previously approved these changes May 27, 2025
@AlexanderLanin AlexanderLanin requested a review from Copilot May 27, 2025 12:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the external prefix regex check by removing defined external id_prefixes from links. It also introduces an additional rst test file and upgrades the score_platform dependency.

  • Fix external prefix removal for links
  • Add an rst file example for links in a folder
  • Upgrade score_platform dependency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/extensions/score_metamodel/checks/id_contains_feature.py Adjusts docname derivation logic for cases when the rst file resides in a folder
src/extensions/score_metamodel/checks/check_options.py Introduces allowed_prefixes to validate_fields and a new remove_prefix function
src/extensions/score_metamodel/init.py Updates configuration by uppercasing prefixes and adding the allowed_external_prefixes config value
examples/linking-both/testing/test.rst Adds an rst example with requirements demonstrating the external prefix removal
examples/linking-both/index.rst Updates requirement IDs to align with the new external prefix handling
MODULE.bazel Upgrades the dependency score_platform from 0.1.0 to 0.1.1

@MaximilianSoerenPollak
Copy link
Contributor Author

Answered copilots concern here: #50 (comment)

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit 75db1e9 into eclipse-score:main May 28, 2025
5 checks passed
@MaximilianSoerenPollak MaximilianSoerenPollak deleted the MSP_bugfix_prefix branch May 28, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Bug: Linking external requirements breaks check

3 participants