-
Notifications
You must be signed in to change notification settings - Fork 20
Bugfix external_prefix regex check #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix external_prefix regex check #50
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: ✅ Passed Click to expand output |
Remove defined external 'id_prefixes' from to be checked links. Added another example to have an rst file inside a folder as well. Added some explanation to descriptions of needs
37d6bf3 to
6749b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the external prefix regex check by removing defined external id_prefixes from links. It also introduces an additional rst test file and upgrades the score_platform dependency.
- Fix external prefix removal for links
- Add an rst file example for links in a folder
- Upgrade score_platform dependency
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/score_metamodel/checks/id_contains_feature.py | Adjusts docname derivation logic for cases when the rst file resides in a folder |
| src/extensions/score_metamodel/checks/check_options.py | Introduces allowed_prefixes to validate_fields and a new remove_prefix function |
| src/extensions/score_metamodel/init.py | Updates configuration by uppercasing prefixes and adding the allowed_external_prefixes config value |
| examples/linking-both/testing/test.rst | Adds an rst example with requirements demonstrating the external prefix removal |
| examples/linking-both/index.rst | Updates requirement IDs to align with the new external prefix handling |
| MODULE.bazel | Upgrades the dependency score_platform from 0.1.0 to 0.1.1 |
|
Answered copilots concern here: #50 (comment) |
Remove defined external 'id_prefixes' from to be checked links.
Added another example to have an rst file inside a folder as well.
Added some explanation to descriptions of needs.
Upgrade dependency of score_platform
closes #47
RST file based tests seem to be more involved than thought, will add these in later PR.
Have to figure our how to implement those first.
Tracking that here #49