feat(lifecycle_client): add MwLifeCycleManagerMock for OSS consumers - #391
Merged
NicolasFussberger merged 2 commits intoJul 30, 2026
Merged
Conversation
Chahult
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
July 30, 2026 11:24
Chahult
temporarily deployed
to
workflow-approval
July 30, 2026 11:24 — with
GitHub Actions
Inactive
Chahult
temporarily deployed
to
workflow-approval
July 30, 2026 11:24 — with
GitHub Actions
Inactive
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
|
The created documentation from the pull request is available at: docu-html |
Closes eclipse-score#265 - Add MwLifeCycleManagerMock that intercepts LifeCycleManager::report_running() and LifeCycleManager::report_shutdown() via global GMock callbacks, allowing unit tests to set expectations on both methods without real IPC calls to the Launch Manager. - Remove the empty report_running() stub from lifecyclemanagermock.cpp; it is now owned by mwlifecyclemanagermock.cpp with a null-safe callback dispatch. - Move report_shutdown() out of the inline header body and into lifecyclemanager.cpp (empty no-op) to allow the mock translation unit to provide a separate definition. - Add mw_lifecycle_manager_mock Bazel target and mw_lifecycle_manager_mock_cc public alias in //score/launch_manager. - lifecycle_mock now depends on mw_lifecycle_manager_mock so existing consumers of lifecycle_mock continue to link without changes. - Add MwLifecycleMockTest fixture and two tests to lifecycle_mocks_UT.cpp.
Chahult
force-pushed
the
feat/add_mw_lifecycle_manager_mock
branch
from
July 30, 2026 12:17
6c28842 to
8dda987
Compare
Chahult
had a problem deploying
to
workflow-approval
July 30, 2026 12:17 — with
GitHub Actions
Failure
Chahult
had a problem deploying
to
workflow-approval
July 30, 2026 12:17 — with
GitHub Actions
Failure
NicolasFussberger
temporarily deployed
to
workflow-approval
July 30, 2026 12:33 — with
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
July 30, 2026 12:33 — with
GitHub Actions
Inactive
NicolasFussberger
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #265