update some needextend directives to affect only the current file - #3158
Merged
Conversation
AlexanderLanin
requested review from
a team,
FScholPer,
anmittag,
antonkri,
johannes-esr and
qor-lb
as code owners
August 5, 2026 00:21
github-project-automation
Bot
added this to
S-CORE Roadmap and TLC - Technical Lead Circle
AlexanderLanin
requested review from
4og,
LittleHuba,
arsibo,
michaelsaborov,
pawelrutkaq,
ramceb,
rmaddikery and
umaucher
as code owners
August 5, 2026 00:21
|
The created documentation from the pull request is available at: docu-html |
a-zw
approved these changes
Aug 5, 2026
RolandJentschETAS
approved these changes
Aug 5, 2026
FScholPer
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since docs-as-code is moving towards supporting more fine grained docs-targets and embedding documentations into documentations, we cannot reliably predict cross document behavior of needextend. Sometimes it may affect a different set of needs than other times.
For example when needextend is applied to "x in docname", and someone else embedds the documentation into their module, and for whatever reason they also have "x", then suddenly the needextend will affect more files/needs.
This was already problematic in reference_integration in the past, we just got lucky due to "unique enough" names. But that will not suffice for a broader rollout.
This PR changes about 10% of needextend directives in score. Those where the change is a single one-liner.
Verification performed: needs_json generated before the change, change applied, needs_json generated again, no diff.