Feat: Add pre-commit, on-pr workflow & cr_checker by MaximilianSoerenPollak · Pull Request #138 · eclipse-score/time

MaximilianSoerenPollak · 2026-07-21T14:28:26Z

This commit adds the cr_checker from the tools repo, It works as replacement of the old one from tooling.
I also added pre-commit to ensure at least some code quality

This commit adds the cr_checker from the `tools` repo. It works as replacement of the old one from tooling. I also added pre-commit to ensure at least some code quality

github-actions · 2026-07-21T14:29:27Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: d8bc1882-69a8-4fe5-8b1b-52c72a35bd8f
Computing main repo mapping: 
WARNING: /home/runner/work/time/time/MODULE.bazel:13:7: The attribute 'compatibility_level' in module() is a no-op and will be removed in a future Bazel release. Please remove it from your MODULE.bazel file.
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (29 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (145 packages loaded, 3104 targets configured)

Analyzing: target //:license-check (154 packages loaded, 6582 targets configured)

Analyzing: target //:license-check (160 packages loaded, 9249 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9302 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9302 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9302 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11190 targets configured)

Analyzing: target //:license-check (169 packages loaded, 11190 targets configured)

INFO: Analyzed target //:license-check (171 packages loaded, 11440 targets configured).
[1 / 1] no actions running
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.301s, Critical Path: 2.55s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-07-21T14:34:01Z

The created documentation from the pull request is available at: docu-html

AlexanderLanin · 2026-07-21T16:00:14Z

Does this run pre-commit in CI? I dont see it. Consider using central on-pr workflow 😄

lavrovvalera · 2026-07-22T07:45:53Z

@@ -0,0 +1 @@
+/home/maximilianp/.cache/bazel/_bazel_maximilianp/e21129910acadb4e6a77c10ca6c1c7f2/execroot/_main/bazel-out/k8-fastbuild/bin/.ide_support


Do we really need a file in the repo?

Sorry this should not be in here, I forgot to add this to .gitignore.

lavrovvalera · 2026-07-22T08:24:58Z


 copyright_checker(
    name = "copyright",
-    srcs = [


So, we donb't need to specify now explicetly the repo structure or folders to check? the fuill repo will be taken by default?

Everything that this command git ls-files --cached --other --exclude-standard will find is now in the cr_checker autoomatically :)

MaximilianSoerenPollak · 2026-07-22T09:12:03Z

 runs:
  using: "docker"
-  image: "jorisroovers/gitlint:0.19.1"
+  image: "docker://jorisroovers/gitlint:0.19.1"


This is needed otherwise it can not infer that the entrypoint should be from the docker and actionlint will give you a warning

MaximilianSoerenPollak · 2026-07-22T09:12:44Z

+paths:
+  .github/workflows/**/*.{yml,yaml}:
+    ignore:
+      - 'file "/bin/sh" does not exist.*entrypoint'


Was the only way I could fix the warning.
It did not accept any other solution, this seems to be accepted workaround (adding the specific thing to the ignore list)

MaximilianSoerenPollak · 2026-07-22T09:13:33Z

+else
+  echo "Could not run '${tool_name}': not available on PATH in a container, and bazel was not found." >&2
+  exit 127
+fi


This file will allow you to run the binaries either from devcontainer or from your system :)

MaximilianSoerenPollak · 2026-07-22T09:18:24Z

-[tool.basedpyright]
-extends = "bazel-bin/ide_support.runfiles/score_tooling+/python_basics/pyproject.toml"
-verboseOutput = true
+# This file is at the root level, as it applies to all Python code,


This is a direct copy of the content of score_tooling+/python_basics/pyproject.toml
You can adapt this as you need it.

The `on-pr` workflow from cicd workflows has all the things we need to execute and has the right permissions.

MaximilianSoerenPollak · 2026-07-22T09:23:07Z

+  common:
+    uses: eclipse-score/cicd-workflows/.github/workflows/on-pr.yml@88cb460c47cb49efeb25cd7b73c8945dd1c5bce2 # on-pr/v0.0.0
+    permissions:
+      contents: read


This workflow will start all needed things in the repo, detecting what is inside the repo and then starting it.

Things like pre-commit for example, that then start other things.

MaximilianSoerenPollak · 2026-07-22T09:24:49Z

@lavrovvalera @AlexanderLanin Please have another look, I addressed the comments and added the missing workflow & removed the not needed file.

MaximilianSoerenPollak · 2026-07-22T13:14:44Z

I removed basedpyright from the pre-commit config. As it's quiet slow.
You can add it back if you think this repo should have this activated.

AlexanderLanin · 2026-07-22T14:37:52Z

@@ -29,17 +30,6 @@ docs(

 copyright_checker(


This repo now has bazel run //:copyright.fix and pre-commit run which do the same thing. Should we really have both?

I think for this PR from my side, yes.
I would let the codeowners decide which part they rather would have and delete that one, the PR has both working and shows how to use / implement it.

AlexanderLanin

LGTM

AlexanderLanin · 2026-07-22T14:39:41Z

@lavrovvalera according to registry you are the maintainer here, but not a committer. What is going on? More importantly: is someone taking care of it?

Feat: Add pre-commit & cr_checker

001c165

This commit adds the cr_checker from the `tools` repo. It works as replacement of the old one from tooling. I also added pre-commit to ensure at least some code quality

github-project-automation Bot added this to TIM - Time FT Jul 21, 2026

github-project-automation Bot moved this to In Progress in TIM - Time FT Jul 21, 2026

MaximilianSoerenPollak had a problem deploying to workflow-approval July 21, 2026 14:28 — with GitHub Actions Error

fix: add pre-commit to README

0cd94bf

MaximilianSoerenPollak had a problem deploying to workflow-approval July 21, 2026 14:37 — with GitHub Actions Error

chore: Fix copyright header

9a5a91c

MaximilianSoerenPollak had a problem deploying to workflow-approval July 21, 2026 14:41 — with GitHub Actions Error

ryan-steel mentioned this pull request Jul 22, 2026

Bugfix: update copyright checker to use docs_sources #135

Closed

lavrovvalera reviewed Jul 22, 2026

View reviewed changes

fix: remove not needed files

0177e58

MaximilianSoerenPollak commented Jul 22, 2026

View reviewed changes

MaximilianSoerenPollak had a problem deploying to workflow-approval July 22, 2026 09:14 — with GitHub Actions Error

fix: Make dev_dependency for devcontainer

5aacc85

MaximilianSoerenPollak had a problem deploying to workflow-approval July 22, 2026 09:15 — with GitHub Actions Error

MaximilianSoerenPollak commented Jul 22, 2026

View reviewed changes

Feat: Add on-pr

f2a798e

The `on-pr` workflow from cicd workflows has all the things we need to execute and has the right permissions.

MaximilianSoerenPollak had a problem deploying to workflow-approval July 22, 2026 09:21 — with GitHub Actions Error

MaximilianSoerenPollak requested a deployment to workflow-approval July 22, 2026 09:21 — with GitHub Actions Waiting

MaximilianSoerenPollak commented Jul 22, 2026

View reviewed changes

MaximilianSoerenPollak requested review from AlexanderLanin and lavrovvalera July 22, 2026 09:24

MaximilianSoerenPollak changed the title ~~Feat: Add pre-commit & cr_checker~~ Feat: Add pre-commit, on-pr workflow & cr_checker Jul 22, 2026

fix: pre-commit command

dc77c23

MaximilianSoerenPollak had a problem deploying to workflow-approval July 22, 2026 09:40 — with GitHub Actions Error

lavrovvalera approved these changes Jul 22, 2026

View reviewed changes

fix: Fix basedpyright pre-commit

3d82bd4

MaximilianSoerenPollak had a problem deploying to workflow-approval July 22, 2026 12:51 — with GitHub Actions Error

fix: Remove basedpyright

6b191ee

MaximilianSoerenPollak requested a deployment to workflow-approval July 22, 2026 13:14 — with GitHub Actions Waiting

AlexanderLanin reviewed Jul 22, 2026

View reviewed changes

AlexanderLanin approved these changes Jul 22, 2026

View reviewed changes

		@@ -0,0 +1 @@
		/home/maximilianp/.cache/bazel/_bazel_maximilianp/e21129910acadb4e6a77c10ca6c1c7f2/execroot/_main/bazel-out/k8-fastbuild/bin/.ide_support No newline at end of file

Uh oh!

Conversation

MaximilianSoerenPollak commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

AlexanderLanin commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak commented Jul 22, 2026

Uh oh!

MaximilianSoerenPollak commented Jul 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexanderLanin left a comment

Choose a reason for hiding this comment

Uh oh!

AlexanderLanin commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 21, 2026 •

edited

Loading

AlexanderLanin commented Jul 21, 2026 •

edited

Loading