[rules score] flatten HTML merge over transitive module closure - #398
Merged
Conversation
hoe-jo
commented
Aug 5, 2026
hoe-jo
commented
Contributor
- SphinxModuleInfo gains own_html_dir and transitive_modules which fixes a diamond-dependency bug: a module required via two or more dependency paths (e.g. A -> B, C; B -> D; C -> D)
- sphinx_html_merge.py: dropped that nested-skip heuristic
- Added module_d_lib test fixture: a diamond dep of both module_b_lib and module_c_lib, asserts its HTML lands exactly once, flat, in the real merged build output.
- SphinxModuleInfo gains own_html_dir and transitive_modules which fixes a diamond-dependency bug: a module required via two or more dependency paths (e.g. A -> B, C; B -> D; C -> D) - sphinx_html_merge.py: dropped that nested-skip heuristic - Added module_d_lib test fixture: a diamond dep of both module_b_lib and module_c_lib, asserts its HTML lands exactly once, flat, in the real merged build output.
hoe-jo
requested review from
LittleHuba,
castler,
limdor and
ramceb
as code owners
August 5, 2026 09:43
castler
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.