Add PersistenceShutdownReleasable opt-in shutdown-release contract - #305
Merged
Conversation
Introduces a marker interface for persisted instances that hold resources which must be released when their owning storage is shut down — background threads, off-heap buffers or auxiliary on-disk files that are not part of the storage's own data files and therefore are not reclaimed by shutting the storage down. On shutdown the storage manager enumerates its object registry (already-loaded instances only, so no Lazy subgraph is force-loaded) and invokes releaseOnShutdown() on every registered instance that implements this interface. Participation is opt-in by design: a plain AutoCloseable is deliberately not triggered, so implementing this interface is an explicit statement that release-on-shutdown is desired. Implementations must be idempotent and must not throw for conditions the caller cannot act on, as the release pass is best-effort.
zdenek-jonas
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a marker interface for persisted instances that hold resources which must be released when their owning storage is shut down — background threads, off-heap buffers or auxiliary on-disk files that are not part of the storage's own data files and therefore are not reclaimed by shutting the storage down. On shutdown the storage manager enumerates its object registry (already-loaded instances only, so no Lazy subgraph is force-loaded) and invokes releaseOnShutdown() on every registered instance that implements this interface.
Participation is opt-in by design: a plain AutoCloseable is deliberately not triggered, so implementing this interface is an explicit statement that release-on-shutdown is desired. Implementations must be idempotent and must not throw for conditions the caller cannot act on, as the release pass is best-effort.