Do I have a bad VSCode dev setup as I have loads of "is not definitely assigned in the constructor" all over code base in the editor

[jonahgraham]

Question

When I open Theia's source files in the VSCode editor I get a bunch of error markers around the @injected properties. Such as

Property 'envVariablesServer' has no initializer and is not definitely assigned in the constructor.

When I open the project in Theia Version 1.71.101 I don't get the error markers.

I can see code standards say to do it like the code does in

theia/.github/instructions/theia-review-code.instructions.md

Lines 22 to 29 in 8904818

	- Property injection, not constructor injection; `@postConstruct` for init; `inSingletonScope()`
	```ts
	// bad — constructor injection is a breaking change
	constructor(@inject(Shell) shell: Shell) { }
	// good
	@inject(Shell) protected readonly shell: Shell;
	```

I have seen the advice elsewhere is to to use !: such as inversify/InversifyJS#1018

Therefore I assume I am having a setup issue in my VSCode dev environment.

[github-actions[bot]]

Hi @jonahgraham, thanks for starting this discussion! 👋

The Theia community will take a look soon. In the meantime, you might find helpful information in:

• 📖 Theia Documentation
• ❓ FAQ
• 💬 Previous Discussions

---

💙 Eclipse Theia is built and maintained by a community of contributors and sponsors. If Theia is valuable to your work, consider sponsoring the project. For professional support, training, or consulting services, learn more about available options.

[msujew]

Hey @jonahgraham,

which version of TypeScript is your VS Code using? It's probably best to change it to the one pinned in the package-lock.json:

I'm getting the same errors when using TypeScript 6.0.3, but it works on 5.9.3. Microsoft did some breaking changes in v6 in preparation for v7 (their Go-port of TypeScript).

[jonahgraham]

Thank you - that seems to be exactly my issue. I now have a clean workspace.