Ship compiled dist/ so @thingweb/code-gen is consumable#80
Merged
egekorkan merged 1 commit intoJul 7, 2026
Merged
Conversation
egekorkan
approved these changes
Jul 7, 2026
Member
|
published 1.0.1 . Good catch... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@thingweb/code-gen@1.0.0(the only version on npm) is broken. Itspackage.jsondeclares
"main": "dist/index.js", but the published tarball shipped only thesrc/*.tsTypeScript sources — no compileddist/. Consumers (bundlers likewebpack, or
node/import) fail to resolve the package:Module not found: Error: Can't resolve '@thingweb/code-gen'
node_modules/@thingweb/code-gen doesn't exist (main -> dist/index.js missing)
Root cause: published without a build step and without a
filesallow-list /prepackhook to guaranteedist/is compiled and included.Changes
package.json"prepack": "npm run build"sodist/is always built before pack/publish."files": ["dist", "README.md", "LICENSE"]allow-list (overrides the.gitignoredistexclusion for the tarball; keepssrc//tests out)."types": "dist/index.d.ts"and a modernexportsmap (types+import).buildtotsc -p tsconfig.build.json.binentry (code-gen→dist/cli.js), kept out of the libraryexports.1.0.0→1.0.1.tsconfig.build.json(new): extendstsconfig.jsonand excludessrc/tests/**so vitest test files are never compiled/shipped.
src/cli.ts: added#!/usr/bin/env nodeshebang so thebinis executable.Release note
Publish
1.0.1after merge to replace the broken1.0.0on npm.