Skip to content

Conversation

@sophokles73
Copy link
Contributor

addresses #180

@sophokles73 sophokles73 force-pushed the check_up_spec_compatibility_in_nightly branch 2 times, most recently from 86f90c7 to 3b04470 Compare August 12, 2024 09:05
@sophokles73 sophokles73 requested a review from evshary August 12, 2024 09:05
@sophokles73 sophokles73 added enhancement New feature or request CI/CD Improvements to the CI/CD pipeline labels Aug 12, 2024
Copy link
Contributor

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just out of curiosity, do you think we should put it inside the nightly.yaml?
Or maybe mention the workflow in the README?

@sophokles73
Copy link
Contributor Author

LGTM Just out of curiosity, do you think we should put it inside the nightly.yaml?

Since I expect this to fail (often?) I'd rather not have it taint the results of the Nightly build which is used to make sure that our main branch builds correctly.

Or maybe mention the workflow in the README?

Yes, that's a good idea. I will add it there ...

A GitHub workflow has been added which fast-forwards the up-spec
submodule to the HEAD revision of up-spec's main branch and then
executes all test cases.

This is used as a canary build to detect any breaking changes that
have been introduced into the uProtocol Specification.
@sophokles73 sophokles73 force-pushed the check_up_spec_compatibility_in_nightly branch from 3b04470 to 7027305 Compare August 12, 2024 11:31
@sophokles73 sophokles73 merged commit 79eca33 into eclipse-uprotocol:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Improvements to the CI/CD pipeline enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants