-
Notifications
You must be signed in to change notification settings - Fork 14
Update with up-transport-vsomeip-rust build changes #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dmacattack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do the READMEs need updating ?
Probably 🧐 |
4e48ea0 to
69ef640
Compare
69ef640 to
3c6cd5d
Compare
3fe3b8e to
b2ef2c3
Compare
|
Hey @ValMobBIllich -- can you take a look? As you were saying, if we get this merged and you rebase on it, then it's likely that #61 builds. |
|
I feel like the env setup would possibly be more compact as a xtask program but I havent looked into those in a while... hard to read through that much bash for me :) The fundamental change is just that the location of the cpp compiler is now dynamically determined which I guess is more stable? |
Exactly, it will be automatically determined for you by running
Yeah, possibly! I'm open to submissions for the like in a follow-up. |
Ditto. Envsetup idea stems from build systems like buildroot, yocto, openWRT, etc. bash is pretty much guaranteed to exist on the runner than anything else, and adds flexibility if the project isn't rust. |
dmacattack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.