[GEF] Fully migrate to the GEF TreeViewer - #1432
Draft
ptziegler wants to merge 1 commit into
Draft
Conversation
Test Results 4 files ±0 4 suites ±0 2h 19m 18s ⏱️ + 6m 25s For more details on these failures, see this check. Results for commit f2ffa8b. ± Comparison against base commit 8e0799c. ♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
gef-tree-viewer
branch
3 times, most recently
from
April 3, 2026 22:27
25d857a to
957cef8
Compare
ptziegler
added a commit
to ptziegler/windowbuilder
that referenced
this pull request
Sep 5, 2026
In order to show the root `ObjectInfo` in the tree viewer, it must not be used as input. For this, it is wrapped inside a `ObjectInfoContainer` when passed to the tree viewer. This will then be transformed into a `ObjectContainerEditPart`, which is the invisible child of the `RootTreeEditPart`. Contributes to eclipse-windowbuilder#1432
ptziegler
added a commit
that referenced
this pull request
Sep 5, 2026
In order to show the root `ObjectInfo` in the tree viewer, it must not be used as input. For this, it is wrapped inside a `ObjectInfoContainer` when passed to the tree viewer. This will then be transformed into a `ObjectContainerEditPart`, which is the invisible child of the `RootTreeEditPart`. Contributes to #1432
ptziegler
force-pushed
the
gef-tree-viewer
branch
from
September 5, 2026 18:05
957cef8 to
68cdfd2
Compare
This removes our copy of the `TreeViewer` and all of its references in favor of the upstream class.
ptziegler
force-pushed
the
gef-tree-viewer
branch
from
September 5, 2026 18:05
68cdfd2 to
f2ffa8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes our copy of the
TreeViewerEditPartandTreeViewerin favor of the upstream classes. In order to use the GEF viewer directly, a virtualDesignComponentedit part needs to be used as contents, holding theTreewidget. Otherwise the edit part of the first model is not shown.