-
Notifications
You must be signed in to change notification settings - Fork 32
Editor context menu basic UI #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor context menu basic UI #158
Conversation
61cf9f9 to
2123e23
Compare
|
@MarcelS4 please update the commit messages to include the information what you want to do here. Force push for updates is OK for me. :-) |
|
Hey @MarcelS4 I still don't know what this should be doing based on the commit message.... Please update the commit message to describe what the propose of this change is. |
2123e23 to
fd69110
Compare
|
@MarcelS4 please check the push results, again this PR seems to contain one unnecessary commit, see https://github.com/eclipse/windowbuilder/pull/158/commits |
|
Interactive rebase is your friend. See https://www.vogella.com/tutorials/EclipseGit/article.html#eclipsegit_interactiverebase |
fd69110 to
f386eea
Compare
|
@vogella thank you. Having a bit of trouble with interactive rebase. Still learning it :) please ignore latest update as it contains the wrong commit |
77cc3d2 to
1ed576f
Compare
|
@vogella could you re-run the workflow? I have tested the culprit in eclipse and it passes. Or could you provide more insight as to why this check fails? |
1ed576f to
c5ada86
Compare
c5ada86 to
b0c6d8f
Compare
|
Tested with Windowbuilder Test suite and got no errors or failures |
|
/rebase |
b0c6d8f to
b503eca
Compare
b503eca to
98e8131
Compare
487fa07 to
406a638
Compare
vogella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a limited context menu is displayed as part of the windowbuilder Basic UI preference Updated copyright Rebased onto latest master
406a638 to
1f2ae7a
Compare
Basic UI version of editor context menu created using the Basic WB UI preference.
Basic UI version of context editor contains only the Copy, paste, cut and delete option
Solution description: I have added preferences to the DesignContextMenuProvider class in the buildContextMenu method. These preferences are not available to the user but can be set by using the InstanceScope. The default for these preferences are set to true and therefore will always show all the actions as previously defined unless the developer incorporating windowbuilder into their product sets the preferences to false.
The two preferences are:
To hide the same actions as are found on the Windowbuilder toolbar, i.e. the Test and Refresh actions




To hide object specific actions that vary depending on which object the context menu is invoked
Following are screenshots of the context menu:
When preferences are set to true
When the toolbar preference is set to false
When the object specific preference is set to false
When both are set to false and only the basic actions remain