Skip to content

Conversation

@MarcelduPreez
Copy link
Contributor

@MarcelduPreez MarcelduPreez commented Jan 25, 2022

Basic UI version of editor context menu created using the Basic WB UI preference.

Basic UI version of context editor contains only the Copy, paste, cut and delete option

Solution description: I have added preferences to the DesignContextMenuProvider class in the buildContextMenu method. These preferences are not available to the user but can be set by using the InstanceScope. The default for these preferences are set to true and therefore will always show all the actions as previously defined unless the developer incorporating windowbuilder into their product sets the preferences to false.

The two preferences are:

To hide the same actions as are found on the Windowbuilder toolbar, i.e. the Test and Refresh actions
To hide object specific actions that vary depending on which object the context menu is invoked
Following are screenshots of the context menu:
When preferences are set to true
image
When the toolbar preference is set to false
image
When the object specific preference is set to false
image
When both are set to false and only the basic actions remain
image

@wimjongman wimjongman added this to the 1.9.9 milestone Mar 14, 2022
@wimjongman wimjongman linked an issue Mar 14, 2022 that may be closed by this pull request
@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from 61cf9f9 to 2123e23 Compare April 20, 2022 07:06
@vogella
Copy link
Contributor

vogella commented Apr 21, 2022

@MarcelS4 please update the commit messages to include the information what you want to do here. Force push for updates is OK for me. :-)

@vogella
Copy link
Contributor

vogella commented May 3, 2022

Hey @MarcelS4 I still don't know what this should be doing based on the commit message.... Please update the commit message to describe what the propose of this change is.

@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from 2123e23 to fd69110 Compare May 4, 2022 09:13
@vogella
Copy link
Contributor

vogella commented May 4, 2022

@MarcelS4 please check the push results, again this PR seems to contain one unnecessary commit, see https://github.com/eclipse/windowbuilder/pull/158/commits

@vogella
Copy link
Contributor

vogella commented May 4, 2022

@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from fd69110 to f386eea Compare May 4, 2022 09:40
@MarcelduPreez
Copy link
Contributor Author

@vogella thank you. Having a bit of trouble with interactive rebase. Still learning it :) please ignore latest update as it contains the wrong commit

@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch 2 times, most recently from 77cc3d2 to 1ed576f Compare May 5, 2022 09:29
@MarcelduPreez
Copy link
Contributor Author

@vogella could you re-run the workflow? I have tested the culprit in eclipse and it passes. Or could you provide more insight as to why this check fails?

@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from 1ed576f to c5ada86 Compare May 17, 2022 09:29
@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from c5ada86 to b0c6d8f Compare June 6, 2022 06:40
@MarcelduPreez
Copy link
Contributor Author

Tested with Windowbuilder Test suite and got no errors or failures

@vogella
Copy link
Contributor

vogella commented Jun 8, 2022

/rebase

@github-actions github-actions bot force-pushed the Editor_Context_Menu_Basic_UI branch from b0c6d8f to b503eca Compare June 8, 2022 07:14
@MarcelduPreez MarcelduPreez force-pushed the Editor_Context_Menu_Basic_UI branch from b503eca to 98e8131 Compare June 8, 2022 08:35
@vogella vogella force-pushed the Editor_Context_Menu_Basic_UI branch 3 times, most recently from 487fa07 to 406a638 Compare June 21, 2022 10:33
@github-actions
Copy link

Unit Test Results

    4 files      4 suites   1m 16s ⏱️
  77 tests   77 ✔️ 0 💤 0
166 runs  166 ✔️ 0 💤 0

Results for commit 406a638.

Copy link
Contributor

@vogella vogella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a limited context menu is displayed as part of the windowbuilder Basic
UI preference
Updated copyright

Rebased onto latest master
@vogella vogella force-pushed the Editor_Context_Menu_Basic_UI branch from 406a638 to 1f2ae7a Compare June 21, 2022 11:39
@MarcelduPreez MarcelduPreez merged commit 1fcdbcf into eclipse-windowbuilder:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limited options for Design Context Menu

3 participants