Skip to content

CAT-FR-SF-04 Align arc42 with upload-path simplification#46

Merged
Sw3eks merged 1 commit into
eclipse-xfsc:mainfrom
federated-catalogue-enhancements-2026:merge-to-upstream/CAT-SF-04_remove-upload-validation-gate
Jun 2, 2026
Merged

CAT-FR-SF-04 Align arc42 with upload-path simplification#46
Sw3eks merged 1 commit into
eclipse-xfsc:mainfrom
federated-catalogue-enhancements-2026:merge-to-upstream/CAT-SF-04_remove-upload-validation-gate

Conversation

@noVaSon

@noVaSon noVaSon commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Summary

Brings the architecture documentation in line with the upload-path simplification on the catalogue side. The verification toggle matrix collapses: the two deploy-time gates that used to fire implicitly on upload (SHACL validation, base-class compliance) are gone. The remaining knobs are envelope semantics and signature verification, which actually carry security value. The credential ingestion strategy is also renamed in narrative, class diagrams, and runtime sequences to reflect that it no longer performs gating — it ingests.

The change keeps the docs honest with the implementation; readers will no longer be misled into believing that a schema=true or require-base-class=true deployment exists.

This change is part of the Enhancement of XFSC Federated Catalogue. Details can be found here (permalink):
https://github.com/eclipse-xfsc/docs/blob/f3c6e6b6fbcc87732a1dfe83f060fa58a9a97873/federated-catalogue/src/docs/CAT%20Enhancement/CAT_Enhancement_Specifications%20v1.0.pdf

✅ What's Changed

  • Feature implemented / Bug fixed
  • Documentation updated
  • Tests added or updated
  • Code formatted and linted

🧪 How to Test

  1. Render the architecture docs (Asciidoctor) and skim chapters 5, 6, 7, 9, and 12.
  2. Confirm there is no surviving prose, table row, or diagram element claiming an automatic upload-time SHACL check or a deploy-time base-class-compliance property.
  3. Confirm the class diagrams and sequence diagrams refer to CredentialIngestionStrategy and that verifyCredential/ingest signatures no longer carry a verifySchema parameter.
  4. The only surviving verifySchema reference is the unrelated SchemaStore.verifySchema(ContentAccessor) utility — that's expected.

🔍 Related Issues

Closes #
Related to #

📸 Screenshots (if applicable)

Reviewers may want to render the arc42 HTML output before/after to compare diagrams visually.

📋 Checklist

  • [n/a] I've tested my code locally
  • [n/a] I've added tests if needed
  • I've updated documentation if necessary
  • My changes follow the project's coding style

* docs(CAT-FR-SF-04): drop deploy-time validation gates from arc42

Removes references to the deploy-time verification.schema and
verification.require-base-class properties from the architecture
chapters. The upload path runs no forced validation; schema validation
is on-demand only via POST /assets/validate (CAT-FR-CO-05). Base-class
compliance is now opt-in per request via requireBaseClass on
POST /verification.

Also renames CredentialVerificationStrategy → CredentialIngestionStrategy
in narrative, class diagrams, and runtime sequences to mirror the code.

Chapters touched: 05 building-block view, 06 runtime view, 07 deployment
view, 09 architecture decisions, 12 glossary.

AC-7 (arc42 portion)

* docs: drop schema row from ADR 3 verification flag table

ADR 3 listed schema among the deploy-time verification toggles, but
schema is no longer one — it has moved entirely to the on-demand
validation path (POST /assets/validate). Updates the prose accordingly
and removes the internal story-ID reference.

* update documentation readme references

* docs(arc42): replace asset upload config table with wiki pointer
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@Sw3eks Sw3eks merged commit 4310978 into eclipse-xfsc:main Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants