CI: build zenoh-flat-jni against published prebindgen - #511
Merged
Conversation
zenoh-flat-jni#23 replaces its single `prebindgen` dependency with the three crates the #371 split produced, so this workflow's two hardcoded per-crate rewrites no longer match anything: the path deps would survive into a checkout that has no sibling `../prebindgen`. One regex over every `../prebindgen/*` dep covers the split and whatever it grows next. The pinned checkouts also move from the stale ZettaScaleLabs forks (last pushed in July) to the eclipse-zenoh repositories the work actually lives in, at the two open PR heads. No Kotlin change: zenoh-flat-jni regenerates byte-identical Kotlin over the split, and all 112 jvmTest cases pass against it locally.
prebindgen 0.5.0 is on crates.io, so zenoh-flat-jni and zenoh-flat declare version constraints and nothing has to be rewritten before the build. Re-pin both checkouts to the PRs that make that switch.
milyin
changed the title
eclipse-zenoh/zenoh-flat#80 merged as 81feb94. zenoh-flat-jni#25 landed on the #24 branch rather than main, so that checkout tracks #24 now.
eclipse-zenoh/zenoh-flat-jni#24 merged as 6f81eb8; both sibling checkouts now sit on their repositories' main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zenoh-flat-jnicheckout this workflow builds no longer keepsprebindgenas a sibling path dependency: prebindgen 0.5.0 is on crates.io, so both it andzenoh-flatnow declare plain version constraints.That deletes the Use prebindgen from GitHub main step outright — the
sedhad nothing left to rewrite. What remains is the checkout re-pointing that motivated this PR originally:ZettaScaleLabs/*→eclipse-zenoh/*, both now onmain.zenoh-flatmain@ 81feb94 (eclipse-zenoh/zenoh-flat#80)zenoh-flat-jnimain@ 6f81eb8 (eclipse-zenoh/zenoh-flat-jni#24)No TODOs left — the whole chain is merged upstream.
Verified
:zenoh-java:jvmTestagainst exactly these two trees via the local composite build: 112 tests, all pass.