Skip to content

Fix: Removed Guava Functional interfaces - #559

Merged
manusa merged 3 commits into
eclipse-jkube:masterfrom
abhijeetshuklaoist:master
Feb 2, 2021
Merged

Fix: Removed Guava Functional interfaces#559
manusa merged 3 commits into
eclipse-jkube:masterfrom
abhijeetshuklaoist:master

Conversation

@abhijeetshuklaoist

@abhijeetshuklaoist abhijeetshuklaoist commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Description

Fix: #546

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov

codecov Bot commented Jan 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #559 (57cacb4) into master (efe7bcc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
+ Coverage     42.04%   42.10%   +0.05%     
- Complexity     2840     2845       +5     
============================================
  Files           402      402              
  Lines         19461    19458       -3     
  Branches       2777     2775       -2     
============================================
+ Hits           8183     8193      +10     
+ Misses        10287    10273      -14     
- Partials        991      992       +1     
Impacted Files Coverage Δ Complexity Δ
.../docker/config/handler/property/ValueProvider.java 75.51% <ø> (ø) 11.00 <0.00> (ø)
...org/eclipse/jkube/kit/common/util/ProcessUtil.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/eclipse/jkube/kit/common/util/EnvUtil.java 76.31% <100.00%> (+7.92%) 54.00 <1.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe7bcc...57cacb4. Read the comment docs.

@ohbus ohbus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 🥳

Please take a look at the following suggestions

Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
@manusa
manusa requested a review from rohanKanojia February 1, 2021 06:17

@rohanKanojia rohanKanojia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for your contribution :-)

@manusa manusa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also add a CHANGELONG.md entry.

Everything else LGTM, thx!

Comment thread jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java Outdated
Signed-off-by: ABHIJEET SHUKLA <abhijeetshuklaoist@gmail.com>
@abhijeetshuklaoist

Copy link
Copy Markdown
Contributor Author

Can someone please help me with figuring out the why sonar-pr check is failing?
Circle CI log says "OpenShift Maven Plugin :: Integration Tests" failed but I am not able to pinpoint what exactly failed.

cc @rohanKanojia @manusa @ohbus

Below is the tail of log:

OpenShift Maven Plugin :: Plugin ................... SUCCESS [ 2.453 s]
[INFO] OpenShift Maven Plugin :: Integration Tests ........ FAILURE [03:40 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:18 min
[INFO] Finished at: 2021-02-01T14:55:15Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.8.0.2131:sonar (sonar) on project openshift-maven-plugin-it:
[ERROR]
[ERROR] The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we stopped accepting it. Please update to at least Java 11.
[ERROR] Temporarily you can set the property 'sonar.scanner.force-deprecated-java-version-grace-period' to 'true' to continue using Java 1.8.0_131
[ERROR] This will only work until Mon Feb 15 09:00:00 UTC 2021, afterwards all scans will fail.
[ERROR] You can find more information here: https://sonarcloud.io/documentation/upcoming/
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :openshift-maven-plugin-it

@rohanKanojia

Copy link
Copy Markdown
Member

Could you please rebase against master? We recently merged #562

@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@manusa
manusa merged commit 8130747 into eclipse-jkube:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use java.util.function.Function instead of Guava's com.google.common.base.Function

4 participants