Fix: Removed Guava Functional interfaces - #559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
============================================
+ Coverage 42.04% 42.10% +0.05%
- Complexity 2840 2845 +5
============================================
Files 402 402
Lines 19461 19458 -3
Branches 2777 2775 -2
============================================
+ Hits 8183 8193 +10
+ Misses 10287 10273 -14
- Partials 991 992 +1
Continue to review full report at Codecov.
|
ohbus
left a comment
There was a problem hiding this comment.
Great PR 🥳
Please take a look at the following suggestions
86eb90f to
e2849d9
Compare
rohanKanojia
left a comment
There was a problem hiding this comment.
👍 Thanks a lot for your contribution :-)
ef07a12 to
dddebd3
Compare
manusa
left a comment
There was a problem hiding this comment.
Please, also add a CHANGELONG.md entry.
Everything else LGTM, thx!
dc4fa42 to
10a1eed
Compare
Signed-off-by: ABHIJEET SHUKLA <abhijeetshuklaoist@gmail.com>
311271b to
64241c2
Compare
|
Can someone please help me with figuring out the why sonar-pr check is failing? cc @rohanKanojia @manusa @ohbus Below is the tail of log: OpenShift Maven Plugin :: Plugin ................... SUCCESS [ 2.453 s] |
|
Could you please rebase against master? We recently merged #562 |
Signed-off-by: ABHIJEET SHUKLA <abhijeetshuklaoist@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
Description
Fix: #546
Type of change
test, version modification, documentation, etc.)
Checklist