Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sonos One player #4429

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
5 participants
@ivivanov-bg
Copy link
Contributor

commented Oct 17, 2017

Add support for Sonos One player

Signed-off-by: Ivaylo Ivanov ivivanov.bg@gmail.com

xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">

<!-- Player ONE Thing Type -->
<thing-type id="One" listed="false">

This comment has been minimized.

Copy link
@kaikreuzer

kaikreuzer Oct 17, 2017

Member

Shouldn't this be better "ONE" in capitals (to be in sync with the PLAYXs?

This comment has been minimized.

Copy link
@ivivanov-bg

ivivanov-bg Oct 17, 2017

Author Contributor

Well - it could be - but the the discovery has to be tuned too because the player announces itself as 'One' and not 'ONE'

This comment has been minimized.

Copy link
@lolodomo

lolodomo Oct 17, 2017

Contributor

The discovery code could ignore the case.

This comment has been minimized.

Copy link
@kaikreuzer

kaikreuzer Oct 17, 2017

Member

I'd agree that it would be better to harden the discovery code.

This comment has been minimized.

Copy link
@FrankZimmer

FrankZimmer Oct 20, 2017

The real Name of Play 1 is "PLAY:1" and the real name of the one is "One" and NOT "ONE". So i recommend to use the real name for the ID. Sonos changed their pattern: http://www.sonos.com/de-de/shop/one.html

This comment has been minimized.

Copy link
@kaikreuzer
@lolodomo
Copy link
Contributor

left a comment

Please add new entries in the translation files, somethiong similar to
thing-type.sonos.CONNECT.label = CONNECT
thing-type.sonos.CONNECT.description = Représente un lecteur pré-ampli Sonos CONNECT
If you don't know how to translate, put the line in comments.

<channel id="sleeptimer" typeId="sleeptimer" />
<channel id="currenttransporturi" typeId="currenttransporturi" />
<channel id="currenttrackuri" typeId="currenttrackuri" />
</channels>

This comment has been minimized.

Copy link
@lolodomo

lolodomo Oct 21, 2017

Contributor

Is there no line-in in the One ? If line-in is present, take example on the PLAY:5.

@lolodomo

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2017

If "One" is kept as thing type id, there is nothing to change in the discovery code.
Please add the following lines in the french translation:
thing-type.sonos.One.label = One
thing-type.sonos.One.description = Représente une enceinte Sonos One

@kaikreuzer
Copy link
Member

left a comment

Please make sure to use the correct spelling "One" throughout the PR, especially in user facing texts.

Add support for Sonos One player
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>

@ivivanov-bg ivivanov-bg force-pushed the ivivanov-bg:add_support_for_sonos_one branch from a85a2bd to fcba4d6 Oct 21, 2017

@kaikreuzer kaikreuzer merged commit 4049898 into eclipse:master Oct 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

hsudbrock added a commit to hsudbrock/smarthome that referenced this pull request Oct 24, 2017

Add support for Sonos One player (eclipse#4429)
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>

@ivivanov-bg ivivanov-bg deleted the ivivanov-bg:add_support_for_sonos_one branch Nov 3, 2017

ivivanov-bg added a commit to ivivanov-bg/smarthome that referenced this pull request Nov 10, 2017

Add support for Sonos One player (eclipse#4429)
Signed-off-by: Ivaylo Ivanov <ivivanov.bg@gmail.com>

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

@openhab-bot

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2018

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sonos-one-discovered-as-zoneplayer-solved/39834/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.