chore: improve id generation#2584
Open
sdirix wants to merge 2 commits into
Open
Conversation
Introduces an `Id` object holding `createId`, `removeId` and `clearAllIds` references and routes all renderer-set callers through it. Adopters can now swap the default implementations.
`createId` previously rescanned the global id set from index 0 on every call. With N identical proposed ids this is O(N^2). Track a per-prefix `next` cursor and a reverse map from id to slot so the scan starts at the lowest unallocated index. `removeId` reuses freed slots by rewinding the cursor. All previously observable behavior is preserved.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
coverage: 83.619% (+0.7%) from 82.946% — id-generation into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2383