Skip to content

feat: normalize dash style in zrender.#628

Merged
pissang merged 9 commits into
ecomfe:nextfrom
plainheart:normalize-dash
Aug 24, 2020
Merged

feat: normalize dash style in zrender.#628
pissang merged 9 commits into
ecomfe:nextfrom
plainheart:normalize-dash

Conversation

@plainheart
Copy link
Copy Markdown
Collaborator

@plainheart plainheart commented Aug 17, 2020 •
edited
Loading

@plainheart plainheart mentioned this pull request Aug 17, 2020
Merged
11 tasks
pissang
pissang requested changes Aug 17, 2020
View reviewed changes
Comment thread src/canvas/graphic.ts
pissang
pissang requested changes Aug 17, 2020
View reviewed changes
Comment thread src/canvas/graphic.ts Outdated
Comment thread src/graphic/helper/dashStyle.ts
pissang
pissang requested changes Aug 18, 2020
View reviewed changes
Comment thread src/graphic/helper/dashStyle.ts
Comment thread src/svg/graphic.ts
@plainheart
Copy link
Copy Markdown
Collaborator Author

plainheart commented Aug 18, 2020 •
edited
Loading

I found there may be something wrong with canvas renderer. The legend symbol also have dash style. This is not expected.
I'm not sure how to fix them.

image

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Aug 20, 2020

I guess it's because the state set by setLineDash in brushText leak to the brushPath.

In brushPath it will use setLineDash([]) to restore the line dash state if it's changed in

zrender/src/canvas/graphic.ts

Line 247 in 5b90035

ctx.setLineDash([]);

It seems brushText doesn't do that.

@plainheart plainheart requested a review from pissang August 21, 2020 03:03
@plainheart
Copy link
Copy Markdown
Collaborator Author

plainheart commented Aug 21, 2020

I just made a commit and should I move the added logic to if (text) block?

@pissang
Copy link
Copy Markdown
Contributor

pissang commented Aug 24, 2020 •
edited
Loading

@plainheart Yeah I think it will be slightly better

@plainheart
Copy link
Copy Markdown
Collaborator Author

plainheart commented Aug 24, 2020

@pissang Done. Please help review it again.

@pissang pissang merged commit 285b489 into ecomfe:next Aug 24, 2020
@plainheart plainheart deleted the normalize-dash branch January 29, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang pissang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plainheart @pissang