[5.0] [FEATURE] more configurable styles for lineStyle & borderStyle. #12961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
|
Looks great! |
plainheart
changed the title
…to more-line-type
…to more-line-type
plainheart
added a commit
to plainheart/zrender
that referenced
this pull request
Jul 20, 2020
…to more-line-type
…to more-line-type
…to more-line-type
pissang
requested changes
Aug 14, 2020
pissang
approved these changes
Aug 28, 2020
|
Congratulations! Your PR has been merged. Thanks for your contribution! |
pissang
changed the title
echarts-bot
bot
added
the
PR: awaiting doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Brief Information
This pull request is in the type of:
What does this PR do?
Support for configuring the following options for
lineStyle.lineDashArray(dashArray)lineDashOffset(dashOffset)lineCap(cap)lineJoin(join)miterLimit(miterLimit)Support for configuring the following options for
border.lineDashArray(borderDashArray)lineDashOffset(borderDashOffset)lineCap(borderCap) (NOT for label text)lineJoin(borderJoin) (NOT for label text)miterLimit(borderMiterLimit) (NOT for label text)TODOs:
linebordertextaxisPointer.labellabelFixed issues
N/A now.
Details
Before: What was the problem?
The line and border lack support for dash styles, such as
dashArray,dashOffset,cap,joinand etc.After: How is it fixed in this PR?
Added some new options about the dash style, as mentioned above.
Usage
Are there any API changes?
Refer to the mentioned above.
Related test cases or examples to use the new APIs
test/line-style.htmlOthers
Merging options
Other information
zrender, please refer to feat: support for dash line scale. ecomfe/zrender#618, feat: normalize dash style in zrender. ecomfe/zrender#628.