fix(task-registry): use dedicated Cancelled status instead of Expired… - #13
Merged
cybermax4200 merged 1 commit intoJul 13, 2026
Merged
Conversation
… for cancel_task Add Cancelled variant to TaskStatus enum so that creator-initiated cancellations are distinguishable from natural expirations. Both complete_task and expire_task already reject non-Active tasks via their existing status guard. Closes ecotask-network#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a creator cancels a task,
cancel_tasksets the status toTaskStatus::Expired, making it impossible to distinguish between a task that timed out and one that was deliberately cancelled. Indexers, UIs, and analytics will misreport cancellations as expirations.Changes
storage.rs: AddedCancelledvariant toTaskStatusenumregistry.rs: Updatedcancel_taskto setTaskStatus::Cancelledinstead ofTaskStatus::Expiredcomplete_taskandexpire_taskreject Cancelled taskstest_cancel_task_by_creatorassertion to expectCancelledBoth
complete_taskandexpire_taskalready reject non-Active tasks via theirtask.status != TaskStatus::Activeguard — no additional logic was needed.Closes #3