Skip to content

Don't set CONFIG_FRAME_WARN in flavor configs#88

Merged
bleggett merged 1 commit into
mainfrom
bleggett/no-set-frame-warn
Jun 3, 2025
Merged

Don't set CONFIG_FRAME_WARN in flavor configs#88
bleggett merged 1 commit into
mainfrom
bleggett/no-set-frame-warn

Conversation

@bleggett

@bleggett bleggett commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

We have been setting CONFIG_FRAME_WARN=1024 in zone/host configs.

This is not set in default upstream kconfigs. Setting it causes (some) kernel builds to fail (i.e. it's not us, it's upstream's code - specifically the amdgpu driver in ~some versions).

  1. Do we need this at all? I doubt it.
  2. Did we need or want this for openpax variants, specifically?

cc @kaniini

@bleggett bleggett requested review from azenla and kaniini June 3, 2025 18:20
@kaniini

kaniini commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

We can drop this.

@azenla azenla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config was originally derived from alpine, so I suspect that might be related to why this was like this

@bleggett bleggett merged commit 7f6cf68 into main Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants