Fix Tests so production publish can pass the gate - #3
Merged
Merged
Conversation
The Tests workflow failed with ERR_REQUIRE_ESM: chai ^5 and jwt-decode ^4 are ESM-only, but test/routes.test.js and src/passport.js require() them. Pin chai to ^4.4.1 and jwt-decode to ^3.1.2 (both CommonJS) and refresh the lockfile.
The "check connection" before-hook only resolved on the "connected" event, but server.js connects at import, so the event usually fired before the hook attached its listener -- timing out the whole suite. Resolve immediately when the connection is already open.
…d it
server.js created the app and called app.listen() but never exported it, so
require("../server") returned {} and every test failed with "app.address is
not a function". Export the app.
The Tests suite is currently obsolete and tracked for a separate rewrite. Publish on push to main like the other services (multi-arch, :latest) so the production image is produced. Tests still run on push/PR but no longer block publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing Tests workflow that gates the production image publish. See commit for root cause. Verifying via CI before this reaches main's publish.