fix: keep retrying an offer while the indexer can accept it - #686
Merged
MoonBoi9001 merged 1 commit intoAug 3, 2026
Merged
Conversation
Dipper posts an offer on chain for each agreement an indexer accepts, and that job gave up after 3 tries: a 95-second outage at the RPC provider burned all 3, leaving 8 minutes of the indexer's 10-minute window to accept unused and the offer lost. The count now follows that window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sizes the retry budget for an on-chain offer from the window the indexer has to accept it, so the job keeps trying while the offer can still land instead of stopping after 3 attempts. Dipper posts an offer on chain for every agreement an indexer accepts off-chain, and until now that job retried a fixed 3 times whatever the deadline was. On 30 July an RPC provider answered with HTTP 500 for about 95 seconds, which was enough to spend all 3 attempts; the offer was then abandoned with 8 minutes of the 10-minute window still open, and the agreement expired without the indexer ever getting it.
With the default 600-second window that works out at 7 attempts spread across the window rather than 3 bunched at the start. An attempt that falls past the deadline ends the job on its own, because the handler already skips an agreement the expiry sweep has moved out of the created state.