feat: add rate limiter for L1 deprecation#889
Merged
Conversation
Theodus
force-pushed
the
theodus/l1-deprecation
branch
from
8ba42e5 to
6cebf1d
Compare
IainM22
reviewed
Jul 16, 2024
gateway-framework/src/auth.rs
Outdated
|
|
||
| if let Some(rate_limiter) = &self.rate_limiter { | ||
| if rate_limiter.above_limit(token) { | ||
| bail!("rate limit exceeded"); |
There was a problem hiding this comment.
Should we mention why its being rate limited? Maybe something along the lines of Rate limit exceeded. Querying L1 subgraphs is deprecated and will be removed soon.
IainM22
approved these changes
Jul 16, 2024
Contributor
|
We already have |
Member
Author
|
@LNSD I don't see how this is "unrelated". We're imposing a limit on API keys similar to checking authorized subgraphs, payment status, etc. So the behavior is all localized, and will be trivial to remove when we no longer need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a per API key rate limiter for the L1 deprecation strategy. Note that this will only be configured on the L1 gateway which only gets 5-15 queries per second total at the time of writing.