Skip to content

fix: handle indexer-service error format#896

Merged
Theodus merged 1 commit intomainfrom
theodus/errors
Jul 22, 2024
Merged

fix: handle indexer-service error format#896
Theodus merged 1 commit intomainfrom
theodus/errors

Conversation

@Theodus
Copy link
Member

@Theodus Theodus commented Jul 22, 2024

The gateway has been failing to provide indexer errors to consumers (just saying no attestation) in some cases because indexer-service is deviating from the expectations of GraphQL over HTTP. Instead of putting errors in the errors, it's using an error field. For example: {"error": "GraphQL server error (client error): Invalid query variables provided"}

@Theodus Theodus requested a review from LNSD July 22, 2024 11:06
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@LNSD
Copy link
Contributor

LNSD commented Jul 22, 2024

Do we know if this behavior is specific to certain version?

@Theodus Theodus merged commit d99f556 into main Jul 22, 2024
@Theodus Theodus deleted the theodus/errors branch July 22, 2024 12:57
@Theodus Theodus mentioned this pull request Jul 22, 2024
Theodus added a commit that referenced this pull request Jul 22, 2024
# Release Notes
- feat: add to indexer & client query kafka messages (#879)
- fix: add optimistic progress to indexing status report (#887)
- feat: add rate limiter for L1 deprecation (#889, #898)
- fix: handle indexer-service error format (#896)
- fix: remove block constraint rewrites (#895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants