Skip to content

fix(portal, timeline): #IMPULS-5879, #IMPULS-5977, responsive flash messages + notifications i18n. - #1108

Merged
jcbe-ode merged 2 commits into
develop-b2schoolfrom
fix-timeline-JCBE
Aug 14, 2026
Merged

fix(portal, timeline): #IMPULS-5879, #IMPULS-5977, responsive flash messages + notifications i18n.#1108
jcbe-ode merged 2 commits into
develop-b2schoolfrom
fix-timeline-JCBE

Conversation

@jcbe-ode

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue.

Fixes

https://edifice-community.atlassian.net/browse/IMPULS-5977
https://edifice-community.atlassian.net/browse/IMPULS-5879

Type of change

Please check options that are relevant.

  • Chore (PATCH)
  • Doc (PATCH)
  • Bug fix (PATCH)
  • New feature (MINOR)

Which packages changed?

Please check the name of the package you changed

  • admin
  • app-registry
  • archive
  • auth
  • cas
  • common
  • communication
  • conversation
  • directory
  • feeder
  • infra
  • portal
  • session
  • test
  • tests
  • timeline
  • workspace

Tests

  • Manual only : updated design and i18n.

Reminder

  • Security flaws

  • Performance impacts (think bulk !)

  • Unit tests were replayed

  • Unit tests were added and/or changed

  • I have updated the reminder for the version including my modifications

  • All done ! 😃

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses UI responsiveness for flash messages in the Timeline root layout and extends Portal i18n entries (notably adding userbook-related labels).

Changes:

  • Timeline: adjust breakpoint logic so flash messages render on all screens below md.
  • Portal: add new French i18n keys for forms and userbook labels.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
timeline/frontend/src/routes/root/index.tsx Updates breakpoint condition to show flash messages on all widths < md.
portal/backend/src/main/resources/i18n/fr.json Adds new French translation keys for forms/userbook-related labels.
Suppressed comments (1)

portal/backend/src/main/resources/i18n/fr.json:1090

  • New translation keys ("forms", "userbook", and the "userbook_*" keys) were added only to fr.json. Since portal also ships en.json and loads translations by Accept-Language, these keys should be added there too to avoid missing/undefined labels for EN users.
  "userbook": "Annuaire",
  "userbook_discovervisiblegroups": "Explorer le réseau",
  "userbook_mood": "Humeurs",
  "userbook_motto": "Devises",

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread portal/backend/src/main/resources/i18n/fr.json
@jcbe-ode
jcbe-ode merged commit 0ac2462 into develop-b2school Aug 14, 2026
2 checks passed
@jcbe-ode
jcbe-ode deleted the fix-timeline-JCBE branch August 14, 2026 07:00
pb-jo pushed a commit that referenced this pull request Aug 14, 2026
…essages + notifications i18n. (#1108)

* fix(homepage): #IMPULS-5879, show alert messages below sm breakpoint

* fix(portal): #IMPULS-5977, add missing i18n keys for notifications outside timeline
vbillard91 pushed a commit that referenced this pull request Aug 26, 2026
…essages + notifications i18n. (#1108)

* fix(homepage): #IMPULS-5879, show alert messages below sm breakpoint

* fix(portal): #IMPULS-5977, add missing i18n keys for notifications outside timeline
jenkinsEdificePublic pushed a commit that referenced this pull request Sep 1, 2026
…essages + notifications i18n. (#1108)

* fix(homepage): #IMPULS-5879, show alert messages below sm breakpoint

* fix(portal): #IMPULS-5977, add missing i18n keys for notifications outside timeline
jenkinsEdificePublic pushed a commit that referenced this pull request Sep 1, 2026
…essages + notifications i18n. (#1108)

* fix(homepage): #IMPULS-5879, show alert messages below sm breakpoint

* fix(portal): #IMPULS-5977, add missing i18n keys for notifications outside timeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants