Fix workspace URI paths with square brackets - #595
Open
emecii wants to merge 2 commits into
Open
Conversation
…-brackets # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594.
Some editor clients send workspace file URIs with raw square brackets.
java.net.URIrejects those characters, causing initialization to fail before the workspace can be opened. This change percent-encodes raw brackets only in the URI path before parsing, while preserving bracketed authorities.Regression coverage exercises raw unmatched opening and closing brackets through the cross-platform URI-to-filename helper.
Validation:
URISyntaxExceptionerrorsclojure -M:test --focus eca.shared-test— 21 tests, 117 assertionsbb test— 931 tests, 5,365 assertionshandlers/initializereproduction withfile:///tmp/work[one]succeedsshared.cljImplementation assistance: OpenAI Codex.