Upgrade all of rails to version 5.2.3

[depfu]

---

Welcome to Depfu 👋

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!

---

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ activerecord (>= 3.2.3, < 5.2.0 → >= 3.2.3, <= 5.2.3) · Repo · Changelog

Release Notes

5.2.3

Active Support

• Add ActiveSupport::HashWithIndifferentAccess#assoc.

  assoc can now be called with either a string or a symbol.

  Stefan Schüßler

• Fix String#safe_constantize throwing a LoadError for incorrectly cased constant references.

  Keenan Brock

• Allow Range#=== and Range#cover? on Range

  Range#cover? can now accept a range argument like Range#include? and
  Range#===. Range#=== works correctly on Ruby 2.6. Range#include? is moved
  into a new file, with these two methods.

  utilum

• If the same block is included multiple times for a Concern, an exception is no longer raised.

  Mark J. Titorenko, Vlad Bokov

Active Model

• Fix date value when casting a multiparameter date hash to not convert
  from Gregorian date to Julian date.

  Before:

  Day.new({"day(1i)"=>"1", "day(2i)"=>"1", "day(3i)"=>"1"})
  => #<Day id: nil, day: "0001-01-03", created_at: nil, updated_at: nil>
  

  After:

  Day.new({"day(1i)"=>"1", "day(2i)"=>"1", "day(3i)"=>"1"})
  => #<Day id: nil, day: "0001-01-01", created_at: nil, updated_at: nil>
  

  Fixes #28521.

  Sayan Chakraborty

• Fix numericality equality validation of BigDecimal and Float
  by casting to BigDecimal on both ends of the validation.

  Gannon McGibbon

Active Record

• Fix different count calculation when using size with manual select with DISTINCT.

  Fixes #35214.

  Juani Villarejo

• Fix prepared statements caching to be enabled even when query caching is enabled.

  Ryuta Kamizono

• Don't allow where with invalid value matches to nil values.

  Fixes #33624.

  Ryuta Kamizono

• Restore an ability that class level update without giving ids.

  Fixes #34743.

  Ryuta Kamizono

• Fix join table column quoting with SQLite.

  Gannon McGibbon

• Ensure that delete_all on collection proxy returns affected count.

  Ryuta Kamizono

• Reset scope after delete on collection association to clear stale offsets of removed records.

  Gannon McGibbon

Action View

• Prevent non-primary mouse keys from triggering Rails UJS click handlers.
  Firefox fires click events even if the click was triggered by non-primary mouse keys such as right- or scroll-wheel-clicks.
  For example, right-clicking a link such as the one described below (with an underlying ajax request registered on click) should not cause that request to occur.

  <%= link_to 'Remote', remote_path, class: 'remote', remote: true, data: { type: :json } %>
  

  Fixes #34541

  Wolfgang Hobmaier

Action Pack

• Allow using combine the Cache Control public and no-cache headers.

  Before this change, even if public was specified for Cache Control header,
  it was excluded when no-cache was included. This fixed to keep public
  header as is.

  Fixes #34780.

  Yuji Yaginuma

• Allow nil params for ActionController::TestCase.

  Ryo Nakamura

Active Job

• No changes.

Action Mailer

• No changes.

Action Cable

• No changes.

Active Storage

• No changes.

Railties

• Seed database with inline ActiveJob job adapter.

  Gannon McGibbon

• Fix boolean interaction in scaffold system tests.

  Gannon McGibbon

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:

• Preparing for 5.2.3 release
• Fix announce script
• Fix release template
• Preparing for 5.2.3.rc1 release
• Fix server restart test on Puma 3.12.1 (#35696)
• Merge pull request #35607 from y-yagi/ensure_application_work_without_tmp_directory
• Fix Gemfile.lock
• Fix secret_key_base for Railties
• Merge branch 'v5-2-2-1' into 5-2-stable
• [ci skip] Improve `encrypted` commands USAGE
• Merge pull request #34965 from bogdanvlviv/improve-rails-encrypted--help

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #16.