Skip to content

Tutor 15 (V15.3.0) Support.#35

Merged
MoisesGSalas merged 1 commit into
eduNEXT:mainfrom
Pearson-Advance:pearson/tutor15.3.0-support
Feb 23, 2023
Merged

Tutor 15 (V15.3.0) Support.#35
MoisesGSalas merged 1 commit into
eduNEXT:mainfrom
Pearson-Advance:pearson/tutor15.3.0-support

Conversation

@Jacatove
Copy link
Copy Markdown
Contributor

@Jacatove Jacatove commented Feb 14, 2023

Description

Support tutor 15 (V15.3.0).

What has changed from Tutor14?

The changes are highlighted in this commit.

Testing Instructions.

Using tutor V15.3.0 install used plugins (tutor-notes, tutor-forum, tutor-minio) and create the manifest files.

tutor drydock save -r drydock/drydock/references/tutor_v15.yml

@Jacatove Jacatove requested a review from a team as a code owner February 14, 2023 15:58
Copy link
Copy Markdown
Member

@MoisesGSalas MoisesGSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jacatove, in addition to the tutor base templates, we also take templates from certain plugins (In our case MinIO and forum).

These can be found in the drydock-jobs/ directory, the idea is to have the definition of the full job as a yaml instead of relying on the tutor cli to generate these jobs for us.

Can you also update these jobs? What we usually do is take the skeleton found in the k8s-jobs patch and add the command from the init task. In that forum example seems like the job added a new env variables so you would need to add them to the drydock-jobs/forum.yaml job, the init task seems to be the same.

I also noticed an error while rendering:

⚠️  Failed to enable plugin 'drydock': module 'tutor.hooks' has no attribute 'filters'

Seems like you would need to do a change here:

-hooks.filters.add_items(
-    "cli:commands",
-    [
-        drydock_command,
-    ],
-)
+hooks.Filters.CLI_COMMANDS.add_item(drydock_command)

@Jacatove
Copy link
Copy Markdown
Contributor Author

@MoisesGSalas Thanks for letting me know how to do it. I have pushed changes regarding the tutor-forum plugin, the other one remains the same, no action needed. About the error, I wonder the context under you are getting that error so I can reproduce it?. I don't see anything when running tutor drydock save -r drydock/drydock/references/tutor_v15.yml .

Comment thread drydock/templates/kustomized/tutor15/extensions/drydock-jobs/lms.yml Outdated
Comment thread drydock/templates/kustomized/tutor15/extensions/overrides.yml Outdated
Copy link
Copy Markdown
Member

@MoisesGSalas MoisesGSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jacatove Jacatove force-pushed the pearson/tutor15.3.0-support branch from 81f89dd to 6022a89 Compare February 20, 2023 16:42
- update forum job according to the k8s-jobs patch from tutor-forum.
- use simplified hooks API introduced in tutor V15.3.0.
- fix getting incompatible yaml files.
- use DRYDOCK_CMS_SSO_USER variable instead of hard coded value.
@Jacatove Jacatove force-pushed the pearson/tutor15.3.0-support branch from 6022a89 to 6ee163e Compare February 23, 2023 14:21
@MoisesGSalas MoisesGSalas merged commit 1e85e46 into eduNEXT:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants