Skip to content

fix: allow to see multiple xblock mindmap in lms#29

Merged
johnvente merged 4 commits into
mainfrom
jv/fix-multiple-xblock-lms-jsmind
Oct 2, 2023
Merged

fix: allow to see multiple xblock mindmap in lms#29
johnvente merged 4 commits into
mainfrom
jv/fix-multiple-xblock-lms-jsmind

Conversation

@johnvente

@johnvente johnvente commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Description
When we create more than one XBlock per unit in the LMS, it breaks due to a draggable plugin from jsmind that was initialized previously, which is weird because each XBlock in the LMS is an iframe. This fix allows us to create any number of XBlocks without that issue

BEFORE NOW

How to test

  1. Once you have the XBlock in your environment, go to Studio > create a unit > create some XBlock-type mind maps.
  2. Publish the changes.
  3. Go to the LMS to see the unit.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets
  • Changelog record added

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was fixed! Thanks

@BryanttV

BryanttV commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@johnvente, when I add more than one block to the unit it does not allow me to display the instructions for use, it closes by itself.

@johnvente

johnvente commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

@johnvente, when I add more than one block to the unit it does not allow me to display the instructions for use, it closes by itself.

@BryanttV Nice catch! I've done the fix for that

@BryanttV

BryanttV commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@johnvente, good! It no longer closes by itself, however, when I open/close one block's instructions, the other blocks do the same.

@johnvente

Copy link
Copy Markdown
Contributor Author

@johnvente, good! It no longer closes by itself, however, when I open/close one block's instructions, the other blocks do the same.

@BryanttV too odd, fixed it! 🚀

@BryanttV

BryanttV commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Perfect! 💯 , LGTM

@johnvente
johnvente merged commit ba978b5 into main Oct 2, 2023
@johnvente
johnvente deleted the jv/fix-multiple-xblock-lms-jsmind branch October 2, 2023 18:09
@johnvente
johnvente restored the jv/fix-multiple-xblock-lms-jsmind branch October 3, 2023 19:04
@mariajgrimaldi
mariajgrimaldi deleted the jv/fix-multiple-xblock-lms-jsmind branch November 24, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants