fix: allow to see multiple xblock mindmap in lms#29
Merged
Conversation
johnvente
requested review from
BryanttV,
Ian2012,
mariajgrimaldi and
nandodev-net
October 2, 2023 15:00
Ian2012
approved these changes
Oct 2, 2023
mariajgrimaldi
approved these changes
Oct 2, 2023
mariajgrimaldi
left a comment
Contributor
There was a problem hiding this comment.
The error was fixed! Thanks
Contributor
|
@johnvente, when I add more than one block to the unit it does not allow me to display the instructions for use, it closes by itself. |
Contributor
Author
@BryanttV Nice catch! I've done the fix for that |
Contributor
|
@johnvente, good! It no longer closes by itself, however, when I open/close one block's instructions, the other blocks do the same. |
Contributor
Author
@BryanttV too odd, fixed it! 🚀 |
Contributor
|
Perfect! 💯 , LGTM |
BryanttV
approved these changes
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we create more than one XBlock per unit in the LMS, it breaks due to a draggable plugin from jsmind that was initialized previously, which is weird because each XBlock in the LMS is an iframe. This fix allows us to create any number of XBlocks without that issue
How to test
Merge checklist:
Check off if complete or not applicable: