Drop support for Python 3.8 and replace pkg_resources with importlib.resources#37
Merged
Conversation
luisfelipec95
changed the title
DeimerM
approved these changes
Feb 7, 2025
DeimerM
left a comment
DeimerM
left a comment
There was a problem hiding this comment.
I have checked the xblock in the sumac release and everything seems to work very well https://studio.sumac.releases.edunext.link/container/block-v1:OpenedX+101+2025+type@vertical+block@3ccdd18b73784358b7b9624623bb1f37#
magajh
requested changes
Feb 11, 2025
|
|
||
| * Remove support for python 3.8 and django 3.2 | ||
| * Replaced deprecated `pkg_resources` APIs with `importlib.resources` and `importlib.metadata` to ensure compatibility with newer Django and Python versions. | ||
| * Starting with this version (9.0.0), it is no longer compatible with Quince. |
Contributor
There was a problem hiding this comment.
What are you trying to say here? I don't understand this message
Contributor
Author
There was a problem hiding this comment.
What do you think about this? Replaced deprecated pkg_resources with importlib.resources for better compatibility with newer Django and Python versions.
Co-authored-by: Maga Giorgianni <maria.jaimes@edunext.co>
magajh
reviewed
Feb 11, 2025
| +------------------+------------------+ | ||
| | Quince | >= 0.8.0 < 2.0.0 | | ||
| +------------------+------------------+ | ||
| | Redwood | >= 1.1.0 | |
Contributor
There was a problem hiding this comment.
@luisfelipec95 why are we changing in this table the compatibility with Redwood and Sumac?
magajh
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pkg_resources (from setuptools) is deprecated and will be removed in future Python versions.
The new implementation uses importlib.resources, which is the recommended alternative and is fully available in Python 3.9+.
Testing instructions
1, Create a Sumac environment using Tutor or TVM.
2. Install xblock-mindmap using this branch you can follow the official tutor documentation.
3. In a course of study:
Navigate to Settings -> Advanced Settings and go to Advanced Module List settings.
Add:
4. Create Unit -> Advance ->Mindmap
Other Information
openedx/public-engineering#273