This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Added german translation and added country name support#273
Closed
beckerr-rzht wants to merge 2 commits intoeduvpn:masterfrom
Closed
Added german translation and added country name support#273beckerr-rzht wants to merge 2 commits intoeduvpn:masterfrom
beckerr-rzht wants to merge 2 commits intoeduvpn:masterfrom
Conversation
* Added support for country name as translation key. Currently in use are "de", "en", "fr" and "nb". See: ``` wget -qO - https://static.eduvpn.nl/disco/institute_access.json \ | jq '.instances[].display_name' | awk -F: '/:/{print $1}' | sort -u ``` * Institution list is sorted after(!) display name translations now.
|
Thanks for the PR! Will look at it soon and make a new release! |
|
@dzolnai did you manage to look at this PR? |
Collaborator
|
Hello @beckerr-rzht, Sorry for taking this long to respond to you about your PR, but we thought it would be better if we would include the strings after we release version 2. |
Merged
Collaborator
|
Closing because #386 has fixed this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added german translation
Added support for country name as translation key.
Currently in use are "de", "en", "fr" and "nb".
See:
Institution list is sorted after(!) display name translations now.