Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Add German translation#386

Merged
dzolnai merged 2 commits intoeduvpn:masterfrom
tribut:feature-german
May 17, 2023
Merged

Add German translation#386
dzolnai merged 2 commits intoeduvpn:masterfrom
tribut:feature-german

Conversation

@tribut
Copy link
Copy Markdown
Contributor

@tribut tribut commented May 11, 2023

This is based on work by @beckerr-rzht, see #273.

All added strings were translated, outdated strings were removed and all existing translations were verified.

This is based on work by @beckerr-rzht. All added strings were
translated, outdated strings were removed and all existing translations
were verified.
Copy link
Copy Markdown
Collaborator

@dzolnai dzolnai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue, almost good

Comment thread app/src/home/res/values-de/strings.xml Outdated
@@ -0,0 +1,45 @@
<!--
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a double copyright header here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, but so do the English and Spanish files :) Probably just copied one of them and didn't have enough courage to clean it up. I've removed all of the duplicated headers now.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then it is our fault after all. Thanks!

@dzolnai dzolnai merged commit d10d022 into eduvpn:master May 17, 2023
@fantostisch fantostisch mentioned this pull request May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants