fix: accessibility issue on video transcripts #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds CSS styling to hide empty subtitle menu items in video blocks. The change ensures that subtitle menu items containing empty spans are not displayed to users.
- Adds a CSS rule to hide subtitle menu items with empty content spans
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Faraz32123
requested review from
djoseph-apphelix,
papphelix,
pganesh-apphelix and
viv-helix
jristau1984
approved these changes
Oct 31, 2025
Faraz32123
deleted the
fix/accessibility_issue_on_video_transcripts_for_edx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: TNL2-405
This PR fixes accessibility issue for video transcripts as when a video component's SRT file has an empty line, the transcript has an empty link that is still interactive.
Empty links should not be interactive and should be hidden from keyboard users as it takes extra click for them when an empty line occurs in the transcript.
Upstream PR: openedx#37587
Before:
before.mov
After:
after.mov