fix: accessibility issue on video transcripts #37587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraz32123
requested review from
farhan,
irtazaakram and
salman2013
as code owners
Faraz32123
requested review from
ormsbee
and removed request for
rayzhou-bit
ormsbee
approved these changes
Nov 26, 2025
Contributor
|
(I squashed just to include more context from the PR into the commit message) |
Member
|
@farhan Heads up that we'll want to make sure to include this change in the extracted block too. |
Contributor
Done, thanks for heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes accessibility issue for video transcripts as when a video component's SRT file has an empty line, the transcript has an empty link that is still interactive.
Empty links should not be interactive and should be hidden from keyboard users as it takes extra click for them when an empty line occurs in the transcript.
Before:
before.mov
After:
after.mov