feat: replace enterprise support view imports with filter calls - #455
Draft
brobro10000 wants to merge 1 commit into
Draft
feat: replace enterprise support view imports with filter calls#455brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
ENT-11574 Sibling of the openedx/openedx-platform PR of the same name, carrying the same call-site change to this deployable fork so it can go through stage/prod ahead of the upstream merge, per the enterprise plugin ticket runbook. Swaps the direct openedx.features.enterprise_support imports in the support contact-us and enrollment views for calls to the new SupportContactContextRequested / SupportEnrollmentDataRequested openedx-filters, and wires up OPEN_EDX_FILTERS_CONFIG for the two new filter types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Sibling of the openedx/openedx-platform PR of the same name, carrying the same call-site
change to this deployable fork so it can go through stage/prod ahead of the upstream merge,
per the enterprise plugin ticket runbook. Devstack only boots this repo (not
openedx/openedx-platform), so this is also the branch used for local integration testing.
Swaps the direct
openedx.features.enterprise_supportimports in the support contact-us andenrollment views for calls to the new
SupportContactContextRequested/SupportEnrollmentDataRequestedopenedx-filters, and wires upOPEN_EDX_FILTERS_CONFIGforthe two new filter types in
lms/envs/common.py. Intentionally does not port theYAML-merge block into
lms/envs/production.py— this file already discourages new_YAML_TOKENSreferences.Related PRs
Merge order (per the enterprise plugin ticket runbook)
Merge this after local devstack testing and before the openedx/openedx-platform PR.
Auto-deploys to stage on merge — test in stage, then deploy to prod and confirm working, before
the openedx-platform PR is rebased and merged.
Testing
Same test changes as the openedx-platform PR:
SupportEnrollmentDataRequested.run_filterandSupportContactContextRequested.run_filterare mocked at the call site inlms/djangoapps/support/tests/test_views.py; the enterprise-specific pipeline-step behavior iscovered by edx-enterprise's own test suite.
Local devstack integration testing (with the openedx-filters, edx-enterprise, and this branch
checked out together) is required before merging — see handoff prompt for exact steps.