manage-only Docker tooling + DOCKER_MCP_ALLOW_CREATE gate (#113)#1
Merged
Merged
Conversation
…gate (#113) Two related changes (the second built on previously-uncommitted working-tree work that the deployed agent-services-hive mcp-docker was already running): 1. Commits the lifecycle handlers + tool entries (start/stop/restart/inspect) that existed only in the working tree on feat/http-transport — addresses the build- from-uncommitted-source drift noted in ADR-006. 2. Adds a manage-only gate: when DOCKER_MCP_ALLOW_CREATE is false (default), hides create-container + deploy-compose from tools/list, refuses them if called, and suppresses the deploy-stack prompt. Pairs with a scoped docker-socket-proxy in the as-hive deployment (which also denies the underlying create/pull API calls) to remove the host bind-mount escape path while keeping lifecycle management. Set the var to true to restore the full lifecycle capability. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports agent-services-hive #113 (scope the Docker socket).
Changes
start/stop/restart/inspecttool entries + handlers existed only in the working tree onfeat/http-transport(the deployed mcp-docker, scored 4.9/5, was built from uncommitted source). This lands them properly (addresses ADR-006 build-drift).DOCKER_MCP_ALLOW_CREATE, defaultfalse):create-container+deploy-composefromtools/listdeploy-stackprompt=truerestores full lifecycle.Why
create-container/deploy-composeallowrun -v /:/host= host root via the Docker socket. Trajectory logs showed zero real use of either. In as-hive this pairs with a scopedwollomatic/socket-proxy(default-deny allowlist) so the underlying create/pull/exec API calls are also blocked — removing the host bind-mount escape while keeping lifecycle management.Verification
Built + deployed in as-hive.
tools/list→ onlyget-logs, list-containers, stop/start/restart-container, inspect-container.create-containercall → refused. Lifecycle ops verified end-to-end through the proxy.🤖 Generated with Claude Code