Move Effect diagnostics to Oxlint - #851
Merged
Merged
Conversation
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Effect diagnostics currently run through the TypeScript language-service patch, while Oxlint is already the repository lint engine. This makes diagnostics differ between editor/compiler and lint workflows.
What
Enable the @effect/tsgo Oxlint integration with type-aware linting, migrate the configured Effect diagnostic severities to Oxlint rules, and disable diagnostics in the language-service plugin. Keep the existing TypeScript 6 / tsgo compiler path unchanged.
The Oxlint upgrade also applies safe type-aware fixes for assertions that the compiler can prove unnecessary.
How
Patch only Oxlint during prepare with
effect-tsgo patch --no-typescript --oxlint. The language-service plugin remains installed but runs withdiagnostics: false.Pragmatic fit: preserve the customized compiler setup and move diagnostics only. Greenfield ideal: adopt @effect/tsgo for both compiler and lint once the remaining compiler customization can be retired; this PR is the reversible diagnostics-first step.
Remarks
Internal tooling only; no flow, machine, or browser behavior changes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.