Add forceScope parameter to useUnit in react

[sagdeev]

Conventions

• Please check your messages against the guidelines if not, perform interactive rebase
• Link an issue your pull request closes or relates

Resolves #765

[netlify]

👷 Deploy request for effector-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	18f74d2

[igorkamyshev]

Sounds great to me 💙

Folks, @effector/core what do you think?

[AlexandrHoroshih]

Hi @sagdeev !
Thanks for contribution!

Everything looks good, but there is a bit of misunderstanding, probably:

In the original issue useUnit without forceScope must try to find the scope from context and if scope is not found - work without it

So overall there a few things missing:

1. Last test snapshot with forceScope: false shoud have a value from scope
2. Need to add another test with forceScope: false and without Provider (should work like it currently works)
3. Need to add isomorphic behaviour

[AlexandrHoroshih]

Hmm, looks like there is a bit of misunderstanding 🤔

In the original issue #765 there is a requirement for an isomorphic behavior, which basically means useUnit without forceScope will try to get scope from context and if its not found -> work like there is no scope

So this test should be updated this way:

Suggested change

	value
	scoped value

[AlexandrHoroshih]

I suggest to add isomorphic behaviour here something like this:

Suggested change

	return useUnitBase(shape, opts?.forceScope ? getScope() : undefined)
	return useUnitBase(shape, getScope(opts?.forceScope))

[AlexandrHoroshih]

It looks like a simplest place to introduce isomorphic behavoir to me, but maybe there a better ones 🤔

I think, it may look like this:

Suggested change

	export function getScope() {
	const scope = React.useContext(ScopeContext)
	if (!scope)
	export function getScope(forceScope?: boolean) {
	const scope = React.useContext(ScopeContext)
	if (forceScope && !scope)

[sergeysova]

I think we need to move getScope out from the ssr.ts file.
Because all export from this module is available to the end-user.

[sagdeev]

@AlexandrHoroshih hi! I think I understand what you were talking about 😃 I made some changes as you requested. Can you please take a look?

• now it works as expected
• update tests
• move getScope to new file and add exports

[AlexandrHoroshih]

@sagdeev Awesome, looks perfect 🔥👍