Fix lint CI: migrate ruff suppressions from noqa to ruff: ignore - #46
Merged
Conversation
ruff 0.16 added three preview rules that these configs opt into via `preview = true`, turning CI red without any change on our side: RUF105 noqa-comments # noqa: X -> # ruff: ignore[X] RUF106 rule-codes-in-suppression-comments code -> readable name RUF201 rule-codes-in-selectors same, for per-file-ignores Suppressions now name the rule they silence, so they read without a lookup table. No behavioural change - comments and config selectors only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint
ruff 0.16 added three preview rules. These configs set
preview = trueanduse an unpinned
astral-sh/ruff-action@v3, so CI went red with no change onour side:
RUF105noqa-comments# noqa: X→# ruff: ignore[X]RUF106rule-codes-in-suppression-commentsRUF201rule-codes-in-selectorsper-file-ignoresSuppressions now name the rule they silence, e.g.
# noqa: PLW3201→# ruff: ignore[bad-dunder-method-name].Fixes were scoped to exactly these three rules rather than a blanket
--fix: ruff's autofix mangles malformed input, turning# noqa RUF067(missing colon) into
# ruff: ignore[...] RUF067with stray trailing text.Comments and config selectors only — no behavioural change.
Verification
ruff checkandruff format --diffboth pass using this workflow's owncommand, and the test suite passes locally via uv.
Not verified: the macOS steps could not be exercised locally (no macOS
runner). Worth watching the first CI run on this PR.
🤖 Generated with Claude Code