Skip to content

feat: define evidence-labelled diagnosis records - #75

Merged
szmyty merged 3 commits into
mainfrom
codex/diagnosis-record-contract
Sep 8, 2026
Merged

feat: define evidence-labelled diagnosis records#75
szmyty merged 3 commits into
mainfrom
codex/diagnosis-record-contract

Conversation

@szmyty

@szmyty szmyty commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • define the provider-neutral diagnosis-record specification
  • add the create-diagnosis-record skill, template, reference, schema, and deterministic evals
  • preserve independent reproduction, root-cause, remediation, validation, sensitivity, and redaction states
  • make narrow-probe and diagnosis-only evidence boundaries explicit
  • regenerate the first-party catalog and distributable skill/spec artifacts
  • update the canonical inventory counts

Closes #74.

Architectural boundary

Aether owns the artifact contract and authoring guidance. Repository templates, structural validation, normalized fleet data, dashboard presentation, and adoption remain downstream responsibilities.

This complements rather than replaces:

  • bug-fixing
  • audit-repository
  • repository-journal
  • ADRs, incident postmortems, and issue trackers

Validation performed

Passed locally:

  • ./aether distribution build --output-directory "dist" --check
  • ./aether validate --format "text"
  • ./aether validate --shell --format "text"
  • ./aether validate --staging --strict-staging --format "text"
  • ./aether catalog generate --check
  • python3 catalog/validate_catalog.py
  • python3 catalog/provenance_model.py check --scope "all"
  • ./aether eval run --mode "deterministic" --format "text"
  • five focused diagnosis-record contract tests
  • 137 tests outside test_consumer_installation_e2e

The complete ./aether test run was not confirmed in this scratch environment: its single consumer-installation test requires a real gh executable; after installing one under /tmp, the runner blocked that test's network access. GitHub PR validation remains the authoritative complete run.

Review focus

  • whether .github/diagnostics/records/<diagnosis-id>.md is the right recommended consumer convention
  • whether the state vocabulary is complete without becoming incident-management policy
  • whether append-only correction and redaction rules are strict enough
  • whether the JSON frontmatter contract exposes the right fields for Egolint and Observatory

@szmyty

szmyty commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please fix the merge conflicts in this pull request.

…d-contract

# Conflicts:
#	catalog/first-party/catalog.v1.json

Co-authored-by: szmyty <14865041+szmyty@users.noreply.github.com>

Copilot AI commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@copilot please fix the merge conflicts in this pull request.

Fixed by merging origin/main into this branch and resolving the catalog conflict in commit 831a639.

@szmyty
szmyty merged commit 3a3780b into main Sep 8, 2026
1 check failed
@szmyty
szmyty deleted the codex/diagnosis-record-contract branch September 8, 2026 13:49
@devactivity-app

Copy link
Copy Markdown

Pull Request Summary by devActivity

Metrics

Cycle Time: 3d 19h 10m Comments: 2

Achievements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define evidence-labelled diagnosis records and authoring skill

2 participants