feat(transforms): add upscayl super-resolution variants - #374
Merged
Conversation
Register Upscayl-NCNN as a local image super-resolution provider with a canonical model catalog, custom model discovery, runtime checksums, bounded execution, GPU and model diagnostics, and provider-variant toolchain evidence. Add spec-v2 variant selectors and a generic tools-variants inspection surface so exhaustive model intent can feed the canonical planner without creating a parallel image-only execution path. Closes #373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Upscayl-NCNN as a first-class local image super-resolution provider and introduces generic provider-variant identity/evidence so model selection can participate in Renderflow planning, provenance, and toolchain/cache fingerprints.
This implements #373 without creating a parallel image-only planner. The pure variant-selection API is designed for the canonical planner/executor work in #354 to consume.
Provider and model catalog
tool.upscayl-ncnnwith capabilityimage.super_resolution.upscayl-ncnnand packagedupscayl-binexecutables through the existing bounded tool probe path..param/.binmodels runtime-discovered rather than silently promoting them to built-ins.Execution and diagnostics
UpscaylAdapterbuilt on the existingProcessExecutorfrom Centralize and harden external tool execution with bounded process policies #356.Generic variant architecture
variant_idand deterministic evidence maps.ExecutionPlanedges and waves.SelectedToolVariantEvidenceto selected-provider toolchain snapshots.target.variant,include.variants, andexclude.variants.select_upscayl_variants(spec, catalog)intent resolution for exact, subset, profile, andall_reachableselection.Policy and publication behavior
Upscayl is local AI super-resolution, so v2 policy remains explicit:
execution.ai: denyblocks selection;local_only/allowopt in.deterministic: truerejects Upscayl because GPU/Vulkan implementations should not be assumed bit-for-bit portable.The model catalog does not assume every bundled model has identical publication rights. Remacri, Ultramix Balanced, and Ultrasharp are recorded as currently labeled Non-Commercial by Upscayl; other bundled models remain
unknownunless separately verified.CLI and docs
Adds a generic variant-inspection surface:
Also adds the super-resolution guide, generated Upscayl model reference, generated tool-registry integration, v2 schema/reference updates, docs drift checks, and the documented opt-in real-GPU smoke command.
Tests
GPU-free coverage includes stable catalog identity, non-commercial metadata, custom model checksums, exhaustive/exact/subset/exclusion selection, AI policy denial, missing executable/model readiness, fake Vulkan readiness, scale evidence, compression validation, variant-sensitive toolchain fingerprints, and provider/model evidence surviving into
ExecutionPlan.Boundary with #354
This PR does not add a second image-specific execution planner. It establishes the provider/model runtime, generic variant identity, selection API, provenance, and fingerprints that #354 can project into the canonical unified execution plan.
Final validation
Final review commit:
9bfc03adac05810b7890332e692ae3cd6ab19bea— one Conventional Commit.All PR-triggered workflows passed on that exact SHA:
33508473754— success33508473822— success33508474061— successCloses #373