Upgrade to the latest version of core and move the repository to Java17#3263
Upgrade to the latest version of core and move the repository to Java17#3263chrisdennis merged 15 commits intoehcache:masterfrom
Conversation
myronkscott
force-pushed
the
update_core
branch
4 times, most recently
from
e3b3523 to
9041c81
Compare
|
Adding as reference this PR also: #3259 |
| * and Striped64. See their internal docs for explanation. | ||
| */ | ||
| @sun.misc.Contended | ||
| static final class CounterCell { |
There was a problem hiding this comment.
@chrisdennis mentioned that we should ideally grab the new changes for this map from the JDK.
There was a problem hiding this comment.
Java17 specific PR?
There was a problem hiding this comment.
that's the title of this one ;-)
There was a problem hiding this comment.
@chrisdennis : I did not check for a new ConcurrentHashMap implementation... Should we grab the new one from the JDK or keep this one, and eventually changing it later ?
mathieucarbou
left a comment
mathieucarbou
left a comment
There was a problem hiding this comment.
some little comments and questions :-)
myronkscott
force-pushed
the
update_core
branch
3 times, most recently
from
4d136b3 to
11eb7a4
Compare
myronkscott
force-pushed
the
update_core
branch
from
11eb7a4 to
952a8e4
Compare
myronkscott
force-pushed
the
update_core
branch
from
952a8e4 to
56135b0
Compare
(but still, there are some spotbugs issues to fix)
|
@chrisdennis please review this PR ;-) |
| project.getExtensions().getExtraProperties().set("testJava", testJava); | ||
|
|
||
| project.getExtensions().configure(JavaPluginExtension.class, java -> { | ||
| java.setSourceCompatibility(JavaVersion.VERSION_1_8); |
There was a problem hiding this comment.
From memory this should be setRelease(...) now?
There was a problem hiding this comment.
I'm not seeing this in the API. What am I missing?
| options.compilerArgs = ['-Xlint:all'] | ||
| } | ||
|
|
||
| afterEvaluate { |
There was a problem hiding this comment.
What drives the need for afterEvaluate(...) here?
There was a problem hiding this comment.
There was a problem hiding this comment.
I suppose this is to access the classes filter that is not available otherwise (https://github.com/spotbugs/spotbugs-gradle-plugin?tab=readme-ov-file#configure-spotbugs-plugin) ?
| terracottaCoreVersion = 5.10.15 | ||
| terracottaPassthroughTestingVersion = 1.9.1 | ||
| terracottaPlatformVersion = 5.11.1 | ||
| terracottaApisVersion = 5.12.+ |
There was a problem hiding this comment.
This should be a fixed version right?
There was a problem hiding this comment.
Copied what Myron has set in platform on the ground that this was discussed already. Looks ok to me to allow this for api.
There was a problem hiding this comment.
Because API is in the same project as runtime, The publishing logic requires us to publish everything api and runtime. This allows us to float the api and bring it in with the runtime. If we fix the API version, build and publishing logic in core is very unorthodox.
myronkscott
force-pushed
the
update_core
branch
from
0e1833d to
aa60546
Compare
4 participants
This is a quick and dirty port to the latest version of core and move the repo to Java17. This is not ready for merge by any means. The purpose is to share ideas. All changes were made to get to the quickest clean build with no thought to appropriate changes to the build system.