[pull] master from IgniteUI:master#133
Merged
Merged
Conversation
* refactor(navdrawer): consume size tokens from theming schema Align the nav drawer with the shared --ig-nav-drawer-size / --ig-nav-drawer-size--mini tokens from igniteui-theming instead of redeclaring the drawer sizes locally. Refs IgniteUI/igniteui-webcomponents#2240 * deps(theming): bump to latest version * fix(navdrawer): prevent initial width animation on first render Consuming the drawer sizes from the theming schema resolves the mini/expanded widths through a var() chain rather than concrete values. As a result, when the aside is first shown as a top-layer popover its width is re-resolved (fallback/expanded -> mini) and, with `transition: width` active, animates on load — a visible flash where previously the width was stable from the first paint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )